raidboss: add Ttokrrone (worldboss: Shaaloani)

[harbingerftw]

This is my first attempt at writing one of these so I'm sure there will be issues, but hopefully not too many. I am not sure if the way some callouts are created will work for localization but that can be re-worked.

There is still an issue I am working out with some rare-ish mechanic combos (sand spouts + orbs + tempests, usually if the fight goes really long) but wanted to go ahead and get feedback in case lots of things do have issues.

I also went ahead and made all the errors from testing go away, not sure if I was supposed to? I did lookup/copy the names of mobs in other languages.
I did talk to @wexxlee about working on this, and will hopefully do the other world boss faster than this.

[wexxlee]

Thanks so much for putting this together! I'm going to try to give this a run in the next few days (when my availability happens to coincide with the fate being up 😁) and see how it feels in game.

[jacob-keller]

Nothing looks too out of place here codewise. I'm not sure when I have a chance to test it out, and I didn't find a good existing log to test in the simulator.

[harbingerftw]

I am going to be going back over more old logs/videos to double check, but this is complete I would say. I have elected to just not deal with the case where the boss rotates before a tempest (incomplete but still helpful callout).
Ttokrrone maybe got more effort than it deserved lol.
Can also share a log, not sure how you would prefer.

[wexxlee]

(Just approved lint/test workflows to be run; haven't been able to test yet, but hoping to do so in the next day or two.)

[xiashtra]

You'll need to add 'missingTranslations': true, to the CN translation block.

[wexxlee]

Again, thanks so much for putting this together! This looked good to me in testing. A few nits below (mostly stylistic & some project-specific conventions).

I have elected to just not deal with the case where the boss rotates before a tempest (incomplete but still helpful callout).

I think that's fair, especially for an initial pass. (I got this combo in testing, incidentally). The callout was still useful enough. I think it would be worth noting this in a TODO at the top of the file, just so we have something besides PR comments to indicate that more could be done with it.

[harbingerftw]

I was going to add the in combat check to the triggers to match other world boss fates but since the triggers interact a lot, someone dying at the wrong time could cause issues so maybe I just leave them out?

I had also already looked up the translations but I forgot to push it seems.

[wexxlee]

I was going to add the in combat check to the triggers to match other world boss fates but since the triggers interact a lot, someone dying at the wrong time could cause issues so maybe I just leave them out?

Yeah, given the cross-pollination between the triggers, I think leaving it commented is fine. Given these fates are not every-hour sort of things, I think it's better to have zone-wide triggers firing during the fate even if the player isn't in combat (e.g. flying in to the battle). If people happen to be in the zone, not in the fate, have cactbot turned on, and don't like the triggers, they have options for that... 😄

[wexxlee]

Changes generally look good to me! Just a few things to close on, and then I think this should be ready.

[wexxlee]

Thanks again for all the work on this!