Skip to content

Conversation

@wexxlee
Copy link
Collaborator

@wexxlee wexxlee commented Sep 24, 2024

No description provided.

@github-actions github-actions bot added oopsy /ui/oopsyraidsy module needs-review Awaiting review labels Sep 24, 2024
@xiashtra
Copy link
Collaborator

There could maybe be a share warn here for non-tanks getting hit by the shared tankbuster, or tanks not sharing it.

@github-actions github-actions bot removed the needs-review Awaiting review label Sep 25, 2024
@wexxlee
Copy link
Collaborator Author

wexxlee commented Sep 26, 2024

There could maybe be a share warn here for non-tanks getting hit by the shared tankbuster, or tanks not sharing it.

Added a TODO for it. It'll definitely require a trigger to handle properly, since it should be a warning to a tank who doesn't get hit by it, and a warn to any non-tank who does get hit. (And nevermind the complications for BLU...)

Related, it's on my todo list to add some state tracking trigger helpers to oopsy, like missedWarn and missedFail for damage that a player should take (e.g. a party stack) and doesn't. Right now, we don't have a helpers to do anything that requires collect/call. But still thinking about the right way to implement it.

@wexxlee wexxlee merged commit 05c2502 into OverlayPlugin:main Sep 26, 2024
@wexxlee wexxlee deleted the oopsy-r3n branch September 26, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oopsy /ui/oopsyraidsy module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants