Skip to content

Conversation

@harbingerftw
Copy link

@harbingerftw harbingerftw commented Oct 10, 2024

I used a script to generate and verify the card patterns based on the many logs I have. Tested what logs I have videos for and in game.

I could not decide on a nice way to call the combo versions of in/out with the line aoes from the hoops so I just took that out.

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Oct 10, 2024
@wexxlee
Copy link
Collaborator

wexxlee commented Oct 12, 2024

Thanks for putting this together! Will try to catch Mica somewhere over the weekend to give it a test run. 😄

return output.protean!();
},
outputStrings: {
protean: 'Protean (x2)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a follow-up call for the second dodge, or some other sort of indication that you should be dodging into the first set of Proteans.

Copy link
Author

@harbingerftw harbingerftw Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did originally want to say something like that. But after looking at other examples where this kind of mechanic happens its never called out.
having said that, I did add it anyway.

@github-actions github-actions bot removed the needs-review Awaiting review label Nov 2, 2024
@github-actions github-actions bot added the needs-review Awaiting review label Nov 2, 2024
Copy link
Collaborator

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triggers get a bit messy when Mica uses Flourishing Bow with Double Misdirect due to timing overlap. Otherwise, the Deal/Draw/Card Trick triggers work well.

@github-actions github-actions bot removed the needs-review Awaiting review label Nov 5, 2024
@github-actions github-actions bot added the needs-review Awaiting review label Nov 5, 2024
Copy link
Collaborator

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good enough to me for now.

@xiashtra xiashtra merged commit fd24fc5 into OverlayPlugin:main Nov 6, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Nov 6, 2024
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
…Memory) (#468)

I used a script to generate and verify the card patterns based on the
many logs I have. Tested what logs I have videos for and in game.

I could not decide on a nice way to call the combo versions of in/out
with the line aoes from the hoops so I just took that out. fd24fc5
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
…Memory) (#468)

I used a script to generate and verify the card patterns based on the
many logs I have. Tested what logs I have videos for and in game.

I could not decide on a nice way to call the combo versions of in/out
with the line aoes from the hoops so I just took that out. fd24fc5
@harbingerftw harbingerftw deleted the fate-mica branch November 15, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants