plugin: update signatures and memory for cn 7.3 #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valarnin
reviewed
Sep 16, 2025
Comment on lines
+109
to
+110
| // Updated in 7.3, signature was no longer unique, include the preceeding "jz LAB_?????????" | ||
| private static String kInCombatSignature = "74??803D??????????74??488B03488BCBFF50"; |
Collaborator
There was a problem hiding this comment.
Did you validate this in the CN client? I'm a bit wary of this being 100% correct because of the required sig change, would like confirmation that it's correct.
Collaborator
Author
There was a problem hiding this comment.
Nope, just a simple copy.
Collaborator
There was a problem hiding this comment.
I'll go ahead and pre-approve this but recommend that it's validated via either of the following before merging:
- Manually scan the executable to make sure the signature is unique in the binary
- Verify that you get the expected
Info: Found in combat memory via InCombatMemory73.output from OverlayPlugin
Collaborator
Author
There was a problem hiding this comment.
Just verified, it is unique.
valarnin
approved these changes
Sep 16, 2025
ShadyWhite
deleted the
plugin-update-signatures-and-memory-for-cn-7.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.