Skip to content

Conversation

@xiashtra
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the util /util label Oct 22, 2025
Copy link
Collaborator

@JLGarber JLGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only able to do floors 1-30 before raid time. I'll try to do 31-40 after my group is done tonight. So far it all looks great apart from the small wording change I suggested.

It might also be nice to add a 3-5 second suppressSeconds to the general duplicated pomander warnings. I can see chest spam causing a lot of noise for people.

@github-actions github-actions bot removed the needs-review Awaiting review label Oct 30, 2025
@xiashtra
Copy link
Collaborator Author

It might also be nice to add a 3-5 second suppressSeconds to the general duplicated pomander warnings. I can see chest spam causing a lot of noise for people.

Disagree; when checking multiple chests in a room, it's a significant slow-down to add an extra 5s to each chest. The noise is a feature in this instance (use your poms, stop holding max stacks for a rainy day!)

@github-actions github-actions bot added the needs-review Awaiting review label Oct 30, 2025
Copy link
Collaborator

@JLGarber JLGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra explanations where needed. Given all that, I think this is good for now.

@github-actions github-actions bot removed the needs-review Awaiting review label Oct 31, 2025
@xiashtra xiashtra merged commit f467e0a into OverlayPlugin:main Oct 31, 2025
13 checks passed
@xiashtra xiashtra deleted the pt-1-40 branch October 31, 2025 03:56
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Oct 31, 2025
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants