Skip to content

Conversation

@jacob-keller
Copy link

The example code for the tank buster response does not match the name
actually used in the file. Fix the capitalization to match the expected
camelCase.

Signed-off-by: Jacob Keller jacob.keller@gmail.com

The example code for the tank buster response does not match the name
actually used in the file. Fix the capitalization to match the expected
camelCase.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
@github-actions github-actions bot added resources /resources needs-review Awaiting review labels Dec 24, 2025
@Legends0
Copy link
Collaborator

That's an interesting catch. What's also similar is the use of sharedTankbuster (and related outputs) does not camel case the buster either, but the response form does.

@github-actions github-actions bot removed the needs-review Awaiting review label Dec 24, 2025
@xiashtra
Copy link
Collaborator

That's an interesting catch. What's also similar is the use of sharedTankbuster (and related outputs) does not camel case the buster either, but the response form does.

We might want to update those for consistency.

@jacob-keller
Copy link
Author

I'd prefer to merge this separately to adjusting and unifying the other names since its essentially a documentation bug fix.

@valarnin
Copy link
Collaborator

We might want to update those for consistency.

I think that sort of change could break user triggers if they're reliant on Outputs, so we should be careful. Maybe put that as a TODO list item for end-of-expansion-content cleanup?

@xiashtra xiashtra merged commit 80109de into OverlayPlugin:main Dec 26, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2025
The example code for the tank buster response does not match the name
actually used in the file. Fix the capitalization to match the expected
camelCase.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>

Signed-off-by: Jacob Keller <jacob.keller@gmail.com> 80109de
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 26, 2025
…erlayPlugin#869)

The example code for the tank buster response does not match the name
actually used in the file. Fix the capitalization to match the expected
camelCase.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>

Signed-off-by: Jacob Keller <jacob.keller@gmail.com> 80109de
@jacob-keller jacob-keller deleted the jk-fix-typo-in-example branch January 4, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resources /resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants