Skip to content

Conversation

@ooo-Jay
Copy link

@ooo-Jay ooo-Jay commented Dec 28, 2025

skipped some of the dungeons which are no longer function after patch 6.x rework

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Dec 28, 2025
@xiashtra
Copy link
Collaborator

skipped some of the dungeons which are no longer function after patch 6.x rework

Which dungeons are you referring to?

@ShadyWhite
Copy link
Collaborator

Due to usage habits, almost all N/S/W/E directional indicators in cactbot triggers are translated as Front/Back/Left/Right in the Simplified Chinese version. I'm not sure if this needs to be changed according to Traditional Chinese user habits.

@xiashtra
Copy link
Collaborator

xiashtra commented Dec 28, 2025

@xiashtra xiashtra mentioned this pull request Dec 28, 2025
@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 28, 2025

skipped some of the dungeons which are no longer function after patch 6.x rework

Which dungeons are you referring to?

ui\raidboss\data\03-hw\dungeon\aetherochemical_research_facility.ts

Lahabrea & Igeyorhm and Ascian Prime didn't fire any trigger, i think the fight is adjusted for the duty support

@xiashtra
Copy link
Collaborator

skipped some of the dungeons which are no longer function after patch 6.x rework

Which dungeons are you referring to?

ui\raidboss\data\03-hw\dungeon\aetherochemical_research_facility.ts

Lahabrea & Igeyorhm and Ascian Prime didn't fire any trigger, i think the fight is adjusted for the duty support

Yes, this is one of the ones that was updated for Duty Support and needs a review. However, some of the earlier triggers should still apply, such as those for Harmachis. I think you should add translations for what you can.

@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 28, 2025

skipped some of the dungeons which are no longer function after patch 6.x rework

Which dungeons are you referring to?

ui\raidboss\data\03-hw\dungeon\aetherochemical_research_facility.ts
Lahabrea & Igeyorhm and Ascian Prime didn't fire any trigger, i think the fight is adjusted for the duty support

Yes, this is one of the ones that was updated for Duty Support and needs a review. However, some of the earlier triggers should still apply, such as those for Harmachis. I think you should add translations for what you can.

yes, tested they are still working, the only missing translation are for "Lahabrea & Igeyorhm and Ascian Prime".

The timing is not 100% correct, a little bit shifting. But i think it is caused by current TC version of FFXIV_ACT_Plugin cannot output "will be sealed off" message, I will test again when new TC version is available.

@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 28, 2025

Due to usage habits, almost all N/S/W/E directional indicators in cactbot triggers are translated as Front/Back/Left/Right in the Simplified Chinese version. I'm not sure if this needs to be changed according to Traditional Chinese user habits.

I suggest changing back to N/S/W/E indicators for better universality.
Since TC server spans across multiple regions with different speaking languages and written languages, so i think a more internationally recognized style would serve well.

@xiashtra
Copy link
Collaborator

You will need to run sync_files to pass the lint checks.

@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 30, 2025

You will need to run sync_files to pass the lint checks.

Thanks.
i am new to GitHub and node.js, i was confusing i should press something in the web or run this locally.
The command caused some warnings, i believe it is a expected warning?
the generated files from the command should be fine?

(node:297504) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:297504) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

@xiashtra
Copy link
Collaborator

You will need to run sync_files to pass the lint checks.

Thanks. i am new to GitHub and node.js, i was confusing i should press something in the web or run this locally. The command caused some warnings, i believe it is a expected warning? the generated files from the command should be fine?

npm run sync-files will execute the script locally.

(node:297504) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:297504) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

These warnings are ok to ignore.

@xiashtra
Copy link
Collaborator

xiashtra commented Dec 30, 2025

Due to changes from #891, you will need to update your local copy of the repository to resolve the conflicts. Unfortunately, a lot of changes were introduced between this PR and that one.

The rule for locale ordering is also being enforced as tc last, which will require some updates to this PR.

@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 30, 2025

Due to changes from #891, you will need to update your local copy of the repository to resolve the conflicts. Unfortunately, a lot of changes were introduced between this PR and that one.

The rule for locale ordering is also being enforced as tc last, which will require some updates to this PR.

sorry for another noob question, does it mean not only moving the tc locale to the last of the locale order, i also have to merge the "main" into my branch, resolve the changes, and commit again?

image

@xiashtra
Copy link
Collaborator

xiashtra commented Dec 30, 2025

Due to changes from #891, you will need to update your local copy of the repository to resolve the conflicts. Unfortunately, a lot of changes were introduced between this PR and that one.
The rule for locale ordering is also being enforced as tc last, which will require some updates to this PR.

sorry for another noob question, does it mean not only moving the tc locale to the last of the locale order, i also have to merge the "main" into my branch, resolve the changes, and commit again?

Yes, that would be the way to handle it. Unfortunately, an issue was caught and resolved which caused a lot of conflicts with your PR; normally it is not this difficult.

@Souma-Sumire
Copy link
Collaborator

Souma-Sumire commented Dec 30, 2025

sorry for another noob question, does it mean not only moving the tc locale to the last of the locale order, i also have to merge the "main" into my branch, resolve the changes, and commit again?

Sorry, the conflict was my mistake.

You can follow the instructions in this image:

~edited~ image

run git checkout --ours .
image


image

Great to see you handled the problem by yourself!

@ooo-Jay
Copy link
Author

ooo-Jay commented Dec 30, 2025

sorry for another noob question, does it mean not only moving the tc locale to the last of the locale order, i also have to merge the "main" into my branch, resolve the changes, and commit again?

Sorry, the conflict was my mistake.

You can follow the instructions in this image:

edited
image
run git checkout --ours . image

image Great to see you handled the problem by yourself!

no worries!
Once the TC server drops 7.0 Savage, more people will probably jump in to help with the TC translation.
Stuff like this will probably happen again, i’m glad i learnt how to handle it now

Thanks for the detailed image guide

Copy link
Collaborator

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge from a technical standpoint; I can't review the actual translations.

@github-actions github-actions bot removed the needs-review Awaiting review label Dec 30, 2025
@xiashtra xiashtra merged commit 084d2c4 into OverlayPlugin:main Dec 30, 2025
12 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 30, 2025
skipped some of the dungeons which are no longer function after patch
6.x rework 084d2c4
github-actions bot pushed a commit that referenced this pull request Dec 30, 2025
skipped some of the dungeons which are no longer function after patch
6.x rework 084d2c4
@ooo-Jay ooo-Jay deleted the i18n-03-hw-tc-update branch January 3, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

raidboss /ui/raidboss module 💬tc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants