-
Notifications
You must be signed in to change notification settings - Fork 75
i18n: tc translation update for 03-hw #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Which dungeons are you referring to? |
|
Due to usage habits, almost all N/S/W/E directional indicators in cactbot triggers are translated as Front/Back/Left/Right in the Simplified Chinese version. I'm not sure if this needs to be changed according to Traditional Chinese user habits. |
|
Lahabrea & Igeyorhm and Ascian Prime didn't fire any trigger, i think the fight is adjusted for the duty support |
Yes, this is one of the ones that was updated for Duty Support and needs a review. However, some of the earlier triggers should still apply, such as those for Harmachis. I think you should add translations for what you can. |
yes, tested they are still working, the only missing translation are for "Lahabrea & Igeyorhm and Ascian Prime". The timing is not 100% correct, a little bit shifting. But i think it is caused by current TC version of FFXIV_ACT_Plugin cannot output "will be sealed off" message, I will test again when new TC version is available. |
I suggest changing back to N/S/W/E indicators for better universality. |
Plus added some missing translation entries in Xelphatol.
|
You will need to run |
Thanks. |
These warnings are ok to ignore. |
|
Due to changes from #891, you will need to update your local copy of the repository to resolve the conflicts. Unfortunately, a lot of changes were introduced between this PR and that one. The rule for locale ordering is also being enforced as |
sorry for another noob question, does it mean not only moving the tc locale to the last of the locale order, i also have to merge the "main" into my branch, resolve the changes, and commit again?
|
Yes, that would be the way to handle it. Unfortunately, an issue was caught and resolved which caused a lot of conflicts with your PR; normally it is not this difficult. |
Sorry, the conflict was my mistake. You can follow the instructions in this image: Great to see you handled the problem by yourself! |
xiashtra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to merge from a technical standpoint; I can't review the actual translations.
skipped some of the dungeons which are no longer function after patch 6.x rework 084d2c4
skipped some of the dungeons which are no longer function after patch 6.x rework 084d2c4







skipped some of the dungeons which are no longer function after patch 6.x rework