forked from quisquous/cactbot
-
Notifications
You must be signed in to change notification settings - Fork 75
raidboss: fix OC CE timelines if already in combat #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiashtra
merged 1 commit into
OverlayPlugin:main
from
jacob-keller:jk-fix-out-of-sync-timeline-oc
Dec 30, 2025
Merged
raidboss: fix OC CE timelines if already in combat #899
xiashtra
merged 1 commit into
OverlayPlugin:main
from
jacob-keller:jk-fix-out-of-sync-timeline-oc
Dec 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the CE timelines have an InCombat sync line to ensure that the timeline matches up with what we expect. In some circumstances, players may accidentally already be in combat when the CE starts. If this occurs, the timeline will never sync up, as the InCombat sync will not be triggered. This results in broken timelines. In many cases the timeline still "appears" but becomes wildly inaccurate. Fix this by increasing the window for the first StartsUsing cast which is used to re-sync the timeline in case of a backup. Ensure this window is large enough to fully cover the 100 seconds skipped at the start of entering a CE.
Author
|
I ran into this today with the Trade Tortoise, somehow I was already in combat and the timeline was completely out of sync. I tested with the log tools and saw that no syncs were triggered. Increasing the initial window fixes this and shows this in the timeline test now: |
xiashtra
approved these changes
Dec 30, 2025
Collaborator
|
LGTM |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
) Most of the CE timelines have an InCombat sync line to ensure that the timeline matches up with what we expect. In some circumstances, players may accidentally already be in combat when the CE starts. If this occurs, the timeline will never sync up, as the InCombat sync will not be triggered. This results in broken timelines. In many cases the timeline still "appears" but becomes wildly inaccurate. Fix this by increasing the window for the first StartsUsing cast which is used to re-sync the timeline in case of a backup. Ensure this window is large enough to fully cover the 100 seconds skipped at the start of entering a CE. 35a543c
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
) Most of the CE timelines have an InCombat sync line to ensure that the timeline matches up with what we expect. In some circumstances, players may accidentally already be in combat when the CE starts. If this occurs, the timeline will never sync up, as the InCombat sync will not be triggered. This results in broken timelines. In many cases the timeline still "appears" but becomes wildly inaccurate. Fix this by increasing the window for the first StartsUsing cast which is used to re-sync the timeline in case of a backup. Ensure this window is large enough to fully cover the 100 seconds skipped at the start of entering a CE. 35a543c
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 30, 2025
…verlayPlugin#899) Most of the CE timelines have an InCombat sync line to ensure that the timeline matches up with what we expect. In some circumstances, players may accidentally already be in combat when the CE starts. If this occurs, the timeline will never sync up, as the InCombat sync will not be triggered. This results in broken timelines. In many cases the timeline still "appears" but becomes wildly inaccurate. Fix this by increasing the window for the first StartsUsing cast which is used to re-sync the timeline in case of a backup. Ensure this window is large enough to fully cover the 100 seconds skipped at the start of entering a CE. 35a543c
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 30, 2025
…verlayPlugin#899) Most of the CE timelines have an InCombat sync line to ensure that the timeline matches up with what we expect. In some circumstances, players may accidentally already be in combat when the CE starts. If this occurs, the timeline will never sync up, as the InCombat sync will not be triggered. This results in broken timelines. In many cases the timeline still "appears" but becomes wildly inaccurate. Fix this by increasing the window for the first StartsUsing cast which is used to re-sync the timeline in case of a backup. Ensure this window is large enough to fully cover the 100 seconds skipped at the start of entering a CE. 35a543c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the CE timelines have an InCombat sync line to ensure that the
timeline matches up with what we expect. In some circumstances, players
may accidentally already be in combat when the CE starts. If this
occurs, the timeline will never sync up, as the InCombat sync will not
be triggered. This results in broken timelines. In many cases the
timeline still "appears" but becomes wildly inaccurate.
Fix this by increasing the window for the first StartsUsing cast which
is used to re-sync the timeline in case of a backup. Ensure this window
is large enough to fully cover the 100 seconds skipped at the start of
entering a CE.