Stack smashing (buffer overflow) detected in debug builds

[gabrielOFlores]

On Linux, when using the ./Build.sh shell script with the debug configuration, OvEditor opens but then crashes; this does not happen if the configuration is set to release version.

It's probably a problem with Make.

[adriengivry]

Hello! Overload doesn't use CMake but premake5.
Instead of using Build.sh, have you tried running make at the root of the repository?

Essentially:

git clone https://github.com/Overload-Technologies/Overload
cd Overload
./gen_proj.sh gmake # generate project files for Makefile
make -j$(nproc) # build the project using all available CPU cores

Then to open Overload:

cd Build/Debug/
./OvEditor

[gabrielOFlores]

Oh yes, sorry, I confused CMake with Makefile haha

And yes, the build with the makefile is still crashing.
Here some log: *** stack smashing detected ***: terminated

[adriengivry]

Would you be able to provide the complete log after running make?

[gabrielOFlores]

Yes!:

==== Building ImGui (debug_x64) ====
==== Building tinyxml2 (debug_x64) ====
==== Building tracy (debug_x64) ====
==== Building lua (debug_x64) ====
==== Building soloud (debug_x64) ====
==== Building glad (debug_x64) ====
==== Building assimp (debug_x64) ====
==== Building glfw (debug_x64) ====
==== Building bullet3 (debug_x64) ====
==== Building OvAudio (debug_x64) ====
==== Building OvCore (debug_x64) ====
==== Building OvDebug (debug_x64) ====
==== Building OvMaths (debug_x64) ====
==== Building OvPhysics (debug_x64) ====
==== Building OvRendering (debug_x64) ====
==== Building OvUI (debug_x64) ====
==== Building OvTools (debug_x64) ====
==== Building OvWindowing (debug_x64) ====
PathParser.cpp
Linking OvTools
==== Building OvGame (debug_x64) ====
Linking OvGame
/usr/bin/ld: ../../Bin/Debug/lua/liblua.a(loslib.o): on function "os_tmpname":
loslib.c:(.text+0x73a): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
Running postbuild commands
mkdir -p ../../Bin/Debug/OvGame/Data
cp -r ../../Resources/Engine ../../Bin/Debug/OvGame/Data/Engine
true
==== Building OvEditor (debug_x64) ====
ActorCreationMenu.cpp
EditorActions.cpp
Linking OvEditor
/usr/bin/ld: ../../Bin/Debug/lua/liblua.a(loslib.o): on function "os_tmpname":
loslib.c:(.text+0x73a): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
Running postbuild commands
rm -rf ../../Build/Debug/Data
mkdir -p ../../Build/Debug/Data
mkdir -p ../../Build/Debug/Config
mkdir -p ../../Build/Debug/Builder/Development
mkdir -p ../../Build/Debug/Builder/Shipping
cp -r ../../Resources/Engine ../../Build/Debug/Data/Engine
cp -r ../../Resources/Editor ../../Build/Debug/Data/Editor
cp ./layout.ini ../../Build/Debug/Config/ 2>/dev/null || true
cp ../../Bin/Debug/OvEditor/OvEditor ../../Build/Debug/
cp ../../Bin/Debug/OvGame/OvGame ../../Build/Debug/Builder/Development/ 2>/dev/null || true
cp ../../Bin/Release/OvGame/OvGame ../../Build/Debug/Builder/Shipping/ 2>/dev/null || true
true

[adriengivry]

Alright so no build issue or particular warning. What kind of GPU are you using? Overload only supports dedicated GPU with OpenGL 4.5

[gabrielOFlores]

Hello! I'm using an Nvidia GPU with proprietary drivers, version 580xx, supporting the latest version of OpenGL (4.6). As I mentioned before, this problem only occurs with the 'debug' configuration of make; if compiled as 'release', everything works normally.

[adriengivry]

Interesting... if you have some bandwidth I would appreciate if you could look into debugging it to know exactly where this buffer overflow is happening.

This post my help:

https://stackoverflow.com/a/1347464

[gabrielOFlores]

Thanks, I'll take a look, if I find anything useful I'll post it here, if I manage to fix it I'll start a Pull Request.

[gabrielOFlores]

Proposal for a fix in PR: #636

[adriengivry]

Thanks for submitting a PR! Let's keep this issue open until the fix is merged.