Crash when an actor using the debug renderer is scaled to 0

[classy-dragon]

Description

Affects:

• Camera
• Reflection Probe

To Reproduce

Steps to reproduce the behavior:

1. Create an reflection probe
2. Go to inspector
3. Set scale (any axis) to 0
4. Engine freeze up
5. Crash :(

Expected behavior

I was trying to make the reflection probe ball more tiny and it crashed

Call Stack

frame #9: 0x0000555556632d28 OvEditor`OvMaths::FQuaternion::ToMatrix4(p_target=0x0000555557d85d74) at FQuaternion.cpp:441:3
frame #10: 0x00005555556cd6ef OvEditor`(anonymous namespace)::CalculateUnscaledModelMatrix(p_actor=0x00005555581f8810) at DebugSceneRenderer.cpp:57:19
frame #11: 0x00005555556d8387 OvEditor`DebugReflectionProbesRenderPass::Draw(this=0x0000555557bb22d0, p_pso=PipelineState @ 0x00007fffffffb6d8) at DebugSceneRenderer.cpp:228:8
frame #12: 0x0000555556654001 OvEditor`OvRendering::Core::CompositeRenderer::DrawFrame(this=0x00005555580ea530) at CompositeRenderer.cpp:61:19
frame #13: 0x00005555555ec424 OvEditor`OvEditor::Panels::AView::DrawFrame(this=0x0000555557bada80) at AView.cpp:85:14
frame #14: 0x000055555579efe9 OvEditor`OvEditor::Panels::SceneView::DrawFrame(this=0x0000555557bada80) at SceneView.cpp:169:39
frame #15: 0x00005555555ec166 OvEditor`OvEditor::Panels::AView::Render(this=0x0000555557bada80) at AView.cpp:76:3
frame #16: 0x00005555556e764d OvEditor`OvEditor::Core::Editor::RenderViews(this=0x0000555557693dc0, p_deltaTime=0.00854325108) at Editor.cpp:247:13
frame #17: 0x00005555556e35be OvEditor`OvEditor::Core::Editor::Update(this=0x0000555557693dc0, p_deltaTime=0.00854325108) at Editor.cpp:100:2
frame #18: 0x00005555556150d4 OvEditor`OvEditor::Core::Application::Run(this=0x0000555557693960) at Application.cpp:29:12
frame #19: 0x0000555555754d62 OvEditor`(anonymous namespace)::TryRun(projectPath=0x00007fffffffdb30) at Main.cpp:72:9

Media

Untitled_video_-_Made_with_Clipchamp_4.mp4

[adriengivry]

It seems like this issue isn't specific to the reflection probe. Essentially, any Actor that goes through the DebugSceneRenderer.cpp (Camera, ReflectionProbe, etc...) using a 3D model with a scale of 0 ends up crashing the engine because of FQuaternion::ToMatrix4(p_actor.transform.GetWorldRotation()); being called with an invalid quaternion