[BUG](system) Fix missing return in BBox dict validator#462
Merged
Victor Schappert (vcschapp) merged 1 commit intodevfrom Mar 11, 2026
Merged
[BUG](system) Fix missing return in BBox dict validator#462Victor Schappert (vcschapp) merged 1 commit intodevfrom
Victor Schappert (vcschapp) merged 1 commit intodevfrom
Conversation
The dict branch of the Pydantic validator in BBox.__get_pydantic_core_schema__ constructed a BBox from the dict but didn't return it, silently producing None. Add the missing return statement. The test parametrize case for dict input covers this path.
Seth Fitzsimmons (sethfitz)
requested a review
from Victor Schappert (vcschapp)
Seth Fitzsimmons (sethfitz)
changed the title
Victor Schappert (vcschapp)
approved these changes
Mar 11, 2026
Roel Bollens (RoelBollens-TomTom)
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dict branch of the Pydantic validator in
BBox.__get_pydantic_core_schema__constructed aBBoxfrom the dict but didn't return it, silently producingNone. Add the missingreturnstatement.The test parametrize case for dict input covers this path.