Skip to content

[SECURITY] Harden GitHub Workflows Pt. 2#496

Merged
John McCall (lowlydba) merged 1 commit intodevfrom
495-devops-followup-github-workflow-hardening
Apr 9, 2026
Merged

[SECURITY] Harden GitHub Workflows Pt. 2#496
John McCall (lowlydba) merged 1 commit intodevfrom
495-devops-followup-github-workflow-hardening

Conversation

@lowlydba
Copy link
Copy Markdown
Contributor

@lowlydba John McCall (lowlydba) commented Apr 9, 2026

Major change release plan

Non-Major change

B. Related MINOR change steps

Non-minor change

C. Public documentation and messaging plan

N/A

Description

The original PR (#493) was accidentally targeting fixes only for a subset of the desired risk level. This closes the gap, and we can confirm it now by the temporary, secondary OMF Security Checks workflow that is using the desired pedantic level.

Prior, due to repo settings it wasn't easily testable until after the workflow had been set as Required.

Reference

N/A

Testing

Proof of pedantic passing (logs):

{6A46B9F6-0621-4CB2-AA6C-457F73F1DE8F}

Signed-off-by: John McCall <john@overturemaps.org>
@lowlydba John McCall (lowlydba) linked an issue Apr 9, 2026 that may be closed by this pull request
@lowlydba John McCall (lowlydba) self-assigned this Apr 9, 2026
@lowlydba John McCall (lowlydba) marked this pull request as ready for review April 9, 2026 18:14
@lowlydba John McCall (lowlydba) requested a review from a team as a code owner April 9, 2026 18:14
Copilot AI review requested due to automatic review settings April 9, 2026 18:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🗺️ Schema reference docs preview is live!

🌍 Preview https://staging.overturemaps.org/schema/pr/496/schema/index.html
🕐 Updated Apr 09, 2026 18:14 UTC
📝 Commit fd71bb7
🔧 env SCHEMA_PREVIEW true

Note

♻️ This preview updates automatically with each push to this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens GitHub Actions workflows to satisfy the intended higher (“pedantic”) security posture (zizmor), primarily by tightening default token permissions, adding concurrency controls, and reducing direct template expansions in shell contexts.

Changes:

  • Add workflow-level permissions: contents: read defaults and more explicit job permissions where needed.
  • Add concurrency groups to reduce duplicate/colliding runs.
  • Refactor some shell steps to use environment variables instead of direct ${{ ... }} expansions (and add zizmor ignore annotations).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/test-schema.yaml Adds workflow permissions defaults, concurrency, and job naming.
.github/workflows/schema-pr-preview.yml Adds explanatory permission comments and uses env vars for PR number in deployment commands; adds a suppression for template-injection.
.github/workflows/schema-pr-preview-cleanup.yml Adds concurrency and uses env vars for PR number in cleanup commands; adds suppression annotations.
.github/workflows/reusable-check-python-package-versions.yaml Adds workflow permissions defaults and job naming; adds a zizmor ignore annotation near an env expression.
.github/workflows/publish-python-packages.yaml Adds concurrency and job naming; refactors publish step to use env vars for matrix fields with zizmor suppressions.
.github/workflows/enforce-change-type-label.yaml Adds workflow permissions defaults, concurrency, and job naming.
.github/workflows/check-python-package-versions.yaml Moves id-token: write from workflow to job-level and adds concurrency.
.github/workflows/check-python-code.yaml Adds workflow permissions defaults, concurrency, and job naming.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lowlydba John McCall (lowlydba) merged commit 04f8969 into dev Apr 9, 2026
13 of 14 checks passed
@lowlydba John McCall (lowlydba) deleted the 495-devops-followup-github-workflow-hardening branch April 9, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Devops] Followup Github Workflow hardening

4 participants