feat: use built triton-windows fork to fix long-path issue#29
Merged
Conversation
Collaborator
|
LGTM, I haven't tested. This impacts windows, the platform for which you are the primary downstream consumer. Ready to merge for convenience with wp-1.5 integration if you're ready. Will be we able to target the official triton-windows in the coming days? |
Author
|
I've tested this and it works, but it might not cover all scenarios; the upstream fix (which has already been merged) should, so the plan is to update to that when possible. I've let them know that we'd appreciate a release being cut, so fingers crossed that I should be able to switch us over in the next few days. Feel free to merge 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for #27 (does not close the issue out). Uses our
triton-windowsfork with a partial longpath fix.