Parser!! #20
Parser!! #20
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| #include "ClassDecl.hpp" | |||
There was a problem hiding this comment.
Each AST node header declares an Accept(AstVisitor&) override, but the corresponding .cpp files (e.g., ClassDecl.cpp) contain only the header include and no definition. Because the classes are non‑abstract, any translation unit that calls ClassDecl::Accept will fail to link and the visitor pattern cannot be used. Provide definitions that dispatch to the appropriate AstVisitor::Visit methods.
Useful? React with 👍 / 👎.
bialger
left a comment
bialger
left a comment
There was a problem hiding this comment.
All in all, titanic work has been done. It is fantastic, and I don't see any major architecture flaws. Although there is a place to grow and some simple mistakes. Please fix them. Really good job, thank you.
No description provided.