Preprocessor (•)(•) #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bialger
requested changes
Oct 26, 2025
Contributor
bialger
left a comment
bialger
left a comment
There was a problem hiding this comment.
Generally a good job. However, there are some code style issues and a problem with ISP at import processor, I recommend separating the graph thing from the rest of the class. And also I would do the thing with include paths in the UI method. All in all, there are some good decisions, but some changes would not hurt.
bialger
requested changes
Oct 28, 2025
Contributor
bialger
left a comment
bialger
left a comment
There was a problem hiding this comment.
All in all a good job! However, I think there is room for improvement: mostly code style, but I suggest using more expandable design in the directive processor. We can merge it after all of these changes are done.
…cy in preprocessor tests
… for submodule management
Add preprocessor tests
bialger
previously approved these changes
Nov 3, 2025
Contributor
bialger
left a comment
bialger
left a comment
There was a problem hiding this comment.
Everything looks fine, a good job!
…ecks and ignore cache files
…apper for multi-operator and keyword checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.