Skip to content

Small ui adjustments for non-video-playback views#348

Merged
mykhailodanilenko merged 1 commit intoOwnTube-tv:mainfrom
mykhailodanilenko:feature/ui-adjustments-and-fixes
May 12, 2025
Merged

Small ui adjustments for non-video-playback views#348
mykhailodanilenko merged 1 commit intoOwnTube-tv:mainfrom
mykhailodanilenko:feature/ui-adjustments-and-fixes

Conversation

@mykhailodanilenko
Copy link
Copy Markdown
Contributor

@mykhailodanilenko mykhailodanilenko commented May 7, 2025

🚀 Description

This PR implements fixes for issues raised in #341, while also making the appearance more consistent on iPads and desktop. See on MishaTube or at cust-app-mishatube.owntube.tv. Also includes fixes for #343 and #346

📄 Motivation and Context

#341, #343, #346

🧪 How Has This Been Tested?

  • Web (desktop)
  • Web (mobile)
  • Mobile (iOS)
  • Mobile (Android)
  • TV (Android)
  • TV (Apple)

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @mykhailodanilenko, @ar9708 and @mblomdahl

@mykhailodanilenko mykhailodanilenko self-assigned this May 7, 2025
@mykhailodanilenko mykhailodanilenko added the figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs label May 7, 2025
ar9708
ar9708 previously requested changes May 8, 2025
Copy link
Copy Markdown
Contributor

@ar9708 ar9708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add #346 and re-request review!

@ar9708
Copy link
Copy Markdown
Contributor

ar9708 commented May 8, 2025

Please mention PR includes #343 as well.

@mykhailodanilenko mykhailodanilenko force-pushed the feature/ui-adjustments-and-fixes branch from b6eac51 to 74c5659 Compare May 8, 2025 09:10
@mykhailodanilenko mykhailodanilenko requested a review from ar9708 May 8, 2025 09:11
@mykhailodanilenko mykhailodanilenko force-pushed the feature/ui-adjustments-and-fixes branch from 74c5659 to afbb66f Compare May 9, 2025 14:57
Copy link
Copy Markdown
Contributor

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing separator, looks great otherwise!

IMG_3728 Medium

@mykhailodanilenko mykhailodanilenko force-pushed the feature/ui-adjustments-and-fixes branch from afbb66f to 33a101f Compare May 12, 2025 06:46
@mykhailodanilenko mykhailodanilenko merged commit 80244af into OwnTube-tv:main May 12, 2025
ar9708 added a commit to ar9708/web-client that referenced this pull request May 12, 2025
ar9708 added a commit that referenced this pull request May 12, 2025
Swedish translations for #348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

figma alignment For issues and PRs that should be shared with Mikael, for aligning Figma designs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants