Skip to content

Conversation

@jamesrweb
Copy link
Member

Proposed Changes

  • Update dependencies
  • Fix the vite build process
  • Migrate to CODEOWNERS instead of using the deprecated reviewers field in the dependabot.yml

Additional Notes (optional)

N / A

@jamesrweb jamesrweb requested a review from yevdyko July 4, 2025 20:15
@jamesrweb jamesrweb self-assigned this Jul 4, 2025
@jamesrweb jamesrweb added dependencies Issues with or changes to dependencies documentation Improvements or additions to documentation security Issues with or changes to security related topics npm labels Jul 4, 2025
yevdyko
yevdyko previously approved these changes Jul 4, 2025
Copy link
Contributor

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@@ -0,0 +1 @@
@jamesrweb @yevdyko No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: missing EOL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this repo doesn't have linting or formatting like the react one does though, maybe we can create another repo with shared configs for eslint, prettier, etc and use the shared configs in this repo and in the react one and any future ones also. WDYT?

My main focus right now is working on the Q5 option, which is in-progress already on my side, and also the migration to P5 version 2.x.x but I haven't started that one. Would you have time to take that on now? If not, I will get to it after the Q5 work I am doing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can take care of it this weekend. Thanks for bringing it up!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesrweb Could you please create a workflows repository under the P5-wrapper organization, as I don't have the permissions to do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the repository and invited you to the organisation, once you accept, I'll assign you maintainer rights to the repos 👌🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have joined the organization and am going to update the workflows repository tomorrow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assigned you maintainer rights in the organisation and so you will have everything you need in current and future repos. Feel free to begin working on the workflows repo and the P5 2.x.x topic when you can ❤️!

* Update peer dependencies to the latest major versions

* 2.0.0
@jamesrweb jamesrweb requested a review from yevdyko July 4, 2025 21:00
@jamesrweb jamesrweb merged commit 6894625 into master Jul 4, 2025
8 checks passed
@jamesrweb jamesrweb deleted the fix-build-and-migrate-to-codeowners branch July 4, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Issues with or changes to dependencies documentation Improvements or additions to documentation npm security Issues with or changes to security related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants