-
Notifications
You must be signed in to change notification settings - Fork 3
Fix build and migrate to codeowners #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yevdyko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 🚀
| @@ -0,0 +1 @@ | |||
| @jamesrweb @yevdyko No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: missing EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, this repo doesn't have linting or formatting like the react one does though, maybe we can create another repo with shared configs for eslint, prettier, etc and use the shared configs in this repo and in the react one and any future ones also. WDYT?
My main focus right now is working on the Q5 option, which is in-progress already on my side, and also the migration to P5 version 2.x.x but I haven't started that one. Would you have time to take that on now? If not, I will get to it after the Q5 work I am doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can take care of it this weekend. Thanks for bringing it up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesrweb Could you please create a workflows repository under the P5-wrapper organization, as I don't have the permissions to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the repository and invited you to the organisation, once you accept, I'll assign you maintainer rights to the repos 👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have joined the organization and am going to update the workflows repository tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assigned you maintainer rights in the organisation and so you will have everything you need in current and future repos. Feel free to begin working on the workflows repo and the P5 2.x.x topic when you can ❤️!
* Update peer dependencies to the latest major versions * 2.0.0
Proposed Changes
Additional Notes (optional)
N / A