Skip to content

Update integration scripts#100

Merged
jamesrweb merged 1 commit intomasterfrom
update-integration-scripts
Jun 25, 2021
Merged

Update integration scripts#100
jamesrweb merged 1 commit intomasterfrom
update-integration-scripts

Conversation

@jamesrweb
Copy link
Member

@jamesrweb jamesrweb commented Jun 23, 2021

This PR fixes the failing CI on master by adding a workflow personal access token into the repository secrets for use when checking out the code inside actions. I also split the responsibilities for what is required when master is pushed to (on merge) and a PR is submitted (on review).

@jamesrweb jamesrweb requested a review from yevdyko June 23, 2021 13:39
@jamesrweb jamesrweb self-assigned this Jun 23, 2021
@jamesrweb jamesrweb force-pushed the update-integration-scripts branch from dc07e70 to 57afdb3 Compare June 23, 2021 14:57
@jamesrweb jamesrweb marked this pull request as ready for review June 23, 2021 15:00
yevdyko
yevdyko previously approved these changes Jun 24, 2021
Copy link
Contributor

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just noticed a redundant step in the PR workflow.

Thanks @jamesrweb!

🚢

@jamesrweb jamesrweb force-pushed the update-integration-scripts branch from e871f7c to e1d0721 Compare June 25, 2021 14:05
Copy link
Contributor

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jamesrweb jamesrweb merged commit 67389ba into master Jun 25, 2021
@jamesrweb jamesrweb deleted the update-integration-scripts branch June 25, 2021 14:53
jamesrweb added a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants