Skip to content

Update installation notes in README #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update installation notes in README #457

merged 1 commit into from
Aug 14, 2024

Conversation

@yevdyko
Copy link
Contributor

@yevdyko yevdyko commented Aug 14, 2024

This PR improves the installation details in the README regarding the use of Typescript proposed by @nooooocato in #437.

Proposed Changes

  • Add comments about installing p5 types when using Typescript.
  • Add a section with required peer dependencies for React P5 Wrapper.
  • Use the correct naming for the Next.js framework.

@yevdyko yevdyko requested a review from jamesrweb August 14, 2024 11:48
@yevdyko yevdyko self-assigned this Aug 14, 2024
@yevdyko yevdyko added the documentation Pull requests that update project documentation label Aug 14, 2024
@jamesrweb jamesrweb merged commit fd701a8 into P5-wrapper:master Aug 14, 2024
@jamesrweb jamesrweb mentioned this pull request Aug 14, 2024
Closed
@yevdyko yevdyko deleted the update-readme branch August 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesrweb jamesrweb jamesrweb approved these changes

Assignees

@yevdyko yevdyko

Labels

documentation Pull requests that update project documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yevdyko @jamesrweb