Skip to content

Conversation

@jamesrweb
Copy link
Member

Proposed Changes

  • Downgrade p5 from version 2.x.x to version 1.x.x
    • The changes there need a new major version to be introduced
    • I am also considering adding an option to use q5 in future and support both in this library.
    • This was the core issue with the CI as tests couldn't pass with the version 2.x.x changes.
  • Remove ts-ignores in the eslint config now that the types are finally exposed by the react team.
  • Update pnpm dependencies and allow builds for local systems of chosen dependencies to allow CI and local to be in sync irregardless of OS.

Additional Notes (optional)

N / A

@jamesrweb jamesrweb requested a review from yevdyko June 1, 2025 15:18
@jamesrweb jamesrweb self-assigned this Jun 1, 2025
@jamesrweb jamesrweb added dependencies Pull requests that update a dependency file security This label applies to security issues labels Jun 1, 2025
@jamesrweb jamesrweb mentioned this pull request Jun 1, 2025
@jamesrweb jamesrweb merged commit a6bb748 into master Jun 1, 2025
9 checks passed
@jamesrweb jamesrweb deleted the fix-ci-issues branch June 1, 2025 22:48
@yevdyko
Copy link
Contributor

yevdyko commented Jun 2, 2025

It's definitely a good idea to add q5 as a new option 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security This label applies to security issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants