Build demo into dist folder#80
Merged
jamesrweb merged 6 commits intoP5-wrapper:masterfrom Mar 30, 2021
yevdyko:chore/build-demo-into-dist-folder
Merged
Build demo into dist folder#80jamesrweb merged 6 commits intoP5-wrapper:masterfrom yevdyko:chore/build-demo-into-dist-folder
jamesrweb merged 6 commits intoP5-wrapper:masterfrom
yevdyko:chore/build-demo-into-dist-folder
Conversation
Contributor
Author
|
@jamesrweb Could you test the deploy script? |
jamesrweb
requested changes
Mar 29, 2021
Member
jamesrweb
left a comment
jamesrweb
left a comment
There was a problem hiding this comment.
Looks good to me, just 2 minor points to change and I can merge once changed! Thanks for the awesome work man, you're on fire!👍🏻
jamesrweb
approved these changes
Mar 30, 2021
jamesrweb
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Format webpack config * Build demo into dist folder * Update deploy script with new build directory path * Remove example build directory from ignore files * Use space indent in the .editorconfig * Use double quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates the Webpack config to build a demo into the
distfolder.What was changed?
distfolder.deployscript with a new build directory path..editorconfig.