Set up testing config#82
Merged
jamesrweb merged 14 commits intoP5-wrapper:masterfrom May 14, 2021
yevdyko:test/setup-testing-config
Merged
Set up testing config#82jamesrweb merged 14 commits intoP5-wrapper:masterfrom yevdyko:test/setup-testing-config
jamesrweb merged 14 commits intoP5-wrapper:masterfrom
yevdyko:test/setup-testing-config
Conversation
jamesrweb
added
dependencies
jamesrweb
requested changes
Apr 10, 2021
Member
jamesrweb
left a comment
jamesrweb
left a comment
There was a problem hiding this comment.
Looks good but I would add at least a render test to be sure it renders properly and is Snapshot-able. Also the linter seems to be failing and cannot be auto fixed, can you look into that?
Contributor
Author
Yeah, I see, but it looks like something went wrong on the Github side as it failed on the first step based on the error: The process '/usr/bin/git' failed with exit code 1I hope this goes away after restarting CI, but I can't find a manual re-run action so let's see if it works after adding a new commit with a render test. |
jamesrweb
reviewed
Apr 12, 2021
yevdyko
commented
Apr 20, 2021
yevdyko
commented
May 8, 2021
jamesrweb
approved these changes
May 14, 2021
jamesrweb
added a commit
that referenced
this pull request
Aug 15, 2022
* Add jest and react testing library * Add jest config * Add first test sample * Fix fetching the repo from the fork branch * Add names to jobs in github actions * Add sketch fixture * Render P5Wrapper component in test * Adding initial render test * Undo dependencies update * Add canvas as dev dependency * Format last changes * Remove unused value * Use head_ref for git-auto-commit action * Run format and auto-correct steps only on push event Co-authored-by: James Robb <47126579+jamesrweb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up a testing config incl. the initial render test and fixes the failed CI.
What was changed?
@jamesrweb I think we can do proper testing in the next PRs and leave only a configuration here.