Merged
Conversation
yevdyko
force-pushed
the
chore/remove-redundant-dotfiles
branch
from
72471f4 to
fea15f3
Compare
jamesrweb
added
dependencies
Member
|
Changed the base branch so that this can be a part of the v3 refactor, I think the next tasks we complete should have their base branch set to there instead of |
jamesrweb
force-pushed
the
refactor/v3
branch
4 times, most recently
from
765dec4 to
86c4ea7
Compare
We control the included files in the published package through the "files" property in the package.json file.
yevdyko
force-pushed
the
chore/remove-redundant-dotfiles
branch
from
8d08d1f to
c66db47
Compare
jamesrweb
approved these changes
Jun 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR removes the redundant dotfiles that can be replaced by using configs in the
package.jsonfile.We can remove the
.npmignorefile because we control the included files in the published package through thefilesproperty in thepackage.jsonfile. The.prettierrcand.eslintignoreconfigs are so minimal that can be easily moved to thepackage.jsonfile too. The rest of the dotfiles are fine for me.What was changed?