ci(DASOPS-2057): fix deploy_prod_legacy — use direct GKE credentials#421
Merged
Conversation
v12 uses direct gcloud container clusters get-credentials instead of Fleet Connect Gateway, fixing the deploy_prod_legacy failure caused by cdip-prod01 (sintegrate-4bb07e9c) not being registered in the Fleet. Also updated prod-legacy env vars: - GKE_CLUTER_NAME: cdip-prod01 -> sintegrate-4bb07e9c - LOCATION: us-central1-c -> us-central1 - PROJECT_ID: cdip-78ca -> cdip-prod1-78ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
deploy_prod_legacywhich has been failing becausecdip-prod01(clustersintegrate-4bb07e9c) is not registered in the serca-tools Fleet.Changes
deploy_prod_legacyfromupdate_k8s_image.yml@v7→@v12— the new version usesgcloud container clusters get-credentialsdirectly instead of Fleet Connect Gatewayprod-legacyGitHub Actions environment variables:GKE_CLUTER_NAME:cdip-prod01→sintegrate-4bb07e9c(actual cluster name)LOCATION:us-central1-c→us-central1(cluster is regional)PROJECT_ID:cdip-78ca→cdip-prod1-78ca(cluster's project)Technical Details
update_k8s_image.yml@v7usedgcloud container fleet memberships get-credentials --project=serca-toolswhich requires the cluster to be in the Fleet. The legacy cluster was never registered there. TheLOCATIONandPROJECT_IDvars already existed in the environment but weren't being used — v12 picks them up for direct GKE auth.Files Changed
1 file changed, 1 insertion(+), 1 deletion(-)
Jira: https://allenai.atlassian.net/browse/DASOPS-2057