Torch input validation#149
Merged
vbharadwaj-bk merged 37 commits intomainfrom Jul 9, 2025
Merged
Conversation
added 30 commits
June 8, 2025 14:18
bringing up to date
…ure is un maintained. I can remove in preferred, but it is convenient.
…ce into shape-checking
…ing all the different buffers and buffer dimensions easier.
added 2 commits
July 8, 2025 21:16
merging with main to enable PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified shape, device, dtype checking in the torch_cpp layer.
Known limitations:
I'm only testing on the forward pass, as there are some guard rails on the backwards pass. In the future, a nice-to-have would be testing the guards on backwards, double-backwards.
Adds pytest-subtests as a dev dependency. I can remove this and go back to "check" but found this gives better diagnostics for which test fails / is better supported.