Adding "_getter" functions in python for TorchBind warnings#152
Merged
vbharadwaj-bk merged 3 commits intomainfrom Aug 7, 2025
Merged
Adding "_getter" functions in python for TorchBind warnings#152vbharadwaj-bk merged 3 commits intomainfrom
vbharadwaj-bk merged 3 commits intomainfrom
Conversation
vbharadwaj-bk
approved these changes
Aug 6, 2025
Member
vbharadwaj-bk
left a comment
vbharadwaj-bk
left a comment
There was a problem hiding this comment.
Looks good to me - is this really a draft or is it ready to merge?
Collaborator
Author
|
It was supposed to be a regular PR. I think my default changed to draft and I forgot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of the "_getter" functions is to match a naming convention that TorchBind expects. This quiets warnings that appeared in the NequIP test. I add irrep_dtype to TP even thought we don't immediately use it just to have it available and similar to the TPConv to maintain a similar interface.