[Refactor] ToastView 에서 iconName 기본값 적용#194
Merged
Merged
Conversation
컨벤션에 맞게 함수 수정
SubView 들 모두 분리 및 ViewModel 잘못된 상속 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항 (Changes)
2cbc13f refactor: ToastView iconName 기본값 반영
변경 이유 (Reason for Changes)
iconName 이 없어도 기본 아이콘이 보이도록 수정.
단, 아이콘 색상에 따라 배경을 어떻게 해야할지 고민 중...
관련 이슈 (Related Issue)
closed #193
테스트 방법 (How to Test)
추가 정보 (Additional Information)