Fix cross-platform command execution in ChangeAnalyze and Repair modules#37
Merged
Conversation
Add platform detection for Windows in addValueForAPI (ChangeAnalyze.py) and validateByRun (repair.py) functions. The following modifications have been made in this submission: 1. ChangeAnalyze.py - addValueForAPI function: - Add platform detection for Windows in the else branch (when runPath is empty) - Use Windows path separator "\\" and "&&" for command chaining on Windows - Keep Linux style with "/" and ";" for Unix-like systems 2. repair.py - validateByRun function: - Add platform detection for Windows in both runPath empty and non-empty cases - Dynamically set Python interpreter path: "python.exe" on Windows, "bin/python" on Linux - Remove hardcoded executable='/bin/bash' parameter for subprocess.run to ensure cross-platform compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add platform detection for Windows in addValueForAPI (ChangeAnalyze.py) and validateByRun (repair.py) functions. The following modifications have been made in this submission:
ChangeAnalyze.py - addValueForAPI function:
repair.py - validateByRun function: