Merged
Conversation
akuntsch
changed the title
akuntsch
force-pushed
the
fix-reachable-and-ipleak-test
branch
3 times, most recently
from
44fd5fd to
dd847b4
Compare
Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc.
akuntsch
force-pushed
the
fix-reachable-and-ipleak-test
branch
from
dd847b4 to
072828b
Compare
xpsony
reviewed
Oct 20, 2024
UmlautAdaptarr/Program.cs
Outdated
| var app = builder.Build(); | ||
|
|
||
| if (app.Configuration.GetValue<bool>("IpLeakTest:Enabled")) { | ||
| Helper.ShowLogo(); |
Contributor
There was a problem hiding this comment.
Ich würde das Logo immer anzeigen lassen
Contributor
Author
There was a problem hiding this comment.
Da hast du absolut recht. Ist angepasst.
akuntsch
force-pushed
the
fix-reachable-and-ipleak-test
branch
from
072828b to
da8ba97
Compare
akuntsch
force-pushed
the
fix-reachable-and-ipleak-test
branch
from
da8ba97 to
27b8eab
Compare
PCJones
approved these changes
Oct 21, 2024
PCJones
added a commit
that referenced
this pull request
Oct 21, 2024
Owner
|
Bitte noch mal neu erstellen mit develop als branch Ziel |
PCJones
added a commit
that referenced
this pull request
Jan 13, 2025
* Fix reachable and IP leak test (#44) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test * Revert "Fix reachable and IP leak test (#44)" (#46) This reverts commit 3f5d7bb. * Release 0.6.1 (#48) * Fix typo * Fix typos * Fix typos * Fix typo * Clarify error message * Fix reachable and ipleak test (#47) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test --------- Co-authored-by: Jonas F <github@pcjones.de> * Add IpLeakTest environment variable to docker compose --------- Co-authored-by: akuntsch <github@akuntsch.de> * Create Dockerfile.arm64 --------- Co-authored-by: akuntsch <github@akuntsch.de>
PCJones
added a commit
that referenced
this pull request
Jan 13, 2025
* Merge master in develop (#55) * Fix reachable and IP leak test (#44) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test * Revert "Fix reachable and IP leak test (#44)" (#46) This reverts commit 3f5d7bb. * Release 0.6.1 (#48) * Fix typo * Fix typos * Fix typos * Fix typo * Clarify error message * Fix reachable and ipleak test (#47) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test --------- Co-authored-by: Jonas F <github@pcjones.de> * Add IpLeakTest environment variable to docker compose --------- Co-authored-by: akuntsch <github@akuntsch.de> * Create Dockerfile.arm64 --------- Co-authored-by: akuntsch <github@akuntsch.de> * Add configurable cache duration * Make proxy port configurable * Make proxy port configurable * Add API Key auth * Add default settings to appsettings --------- Co-authored-by: akuntsch <github@akuntsch.de>
PCJones
added a commit
that referenced
this pull request
Jan 13, 2025
* Merge master in develop (#55) * Fix reachable and IP leak test (#44) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test * Revert "Fix reachable and IP leak test (#44)" (#46) This reverts commit 3f5d7bb. * Release 0.6.1 (#48) * Fix typo * Fix typos * Fix typos * Fix typo * Clarify error message * Fix reachable and ipleak test (#47) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test --------- Co-authored-by: Jonas F <github@pcjones.de> * Add IpLeakTest environment variable to docker compose --------- Co-authored-by: akuntsch <github@akuntsch.de> * Create Dockerfile.arm64 --------- Co-authored-by: akuntsch <github@akuntsch.de> * Add configurable cache duration * Make proxy port configurable * Make proxy port configurable * Add API Key auth * Add default settings to appsettings * Fix too many Unauthorized access attempt warnings --------- Co-authored-by: akuntsch <github@akuntsch.de>
PCJones
added a commit
that referenced
this pull request
Jan 13, 2025
* Merge master in develop (#55) * Fix reachable and IP leak test (#44) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test * Revert "Fix reachable and IP leak test (#44)" (#46) This reverts commit 3f5d7bb. * Release 0.6.1 (#48) * Fix typo * Fix typos * Fix typos * Fix typo * Clarify error message * Fix reachable and ipleak test (#47) * Fix reachable check Fixes failing reachable checks when Basic Authentication is enabled in Sonarr, Radarr, etc. * Add option to disable IP leak test --------- * Add IpLeakTest environment variable to docker compose --------- * Create Dockerfile.arm64 --------- * Add configurable cache duration * Make proxy port configurable * Make proxy port configurable * Add API Key auth * Add default settings to appsettings * Fix too many Unauthorized access attempt warnings --------- Co-authored-by: akuntsch <github@akuntsch.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the instance reachable checks when Basic Authentication is enabled in the *arr instance by GETing
/api?apikey=<ApiKey>instead of/without any authentication.I'm not 100% sure that all supported *arrs return HTTP 200 when GETing
/api, but it seems to work for Sonarr and Readarr on my end.Also added a configuration option to disable the IP leak test. Setting
IPLEAKTEST__ENABLED=falseas docker environment variable will disable the check.Fixes #40.