Skip to content

refactor: SMTC 改进#445

Merged
Hill23333 merged 5 commits intoPCL-Community:devfrom
Creative-Generator:smtc-improve
Apr 13, 2025
Merged

refactor: SMTC 改进#445
Hill23333 merged 5 commits intoPCL-Community:devfrom
Creative-Generator:smtc-improve

Conversation

@Hill23333
Copy link
Copy Markdown
Contributor

现在 SMTC 的读取更加准确,这对 Lyricify Lite 等软件的识别提供了帮助。

@Hill23333 Hill23333 requested a review from a team April 12, 2025 15:10
@wyc-26
Copy link
Copy Markdown
Contributor

wyc-26 commented Apr 12, 2025

image
ummm,这三个文件是什么情况

@LinQingYuu LinQingYuu added the 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 label Apr 12, 2025
@Hill23333
Copy link
Copy Markdown
Contributor Author

ummm,这三个文件是什么情况

我不清楚(
应该是 git 的神奇 Bug 吧

Copy link
Copy Markdown
Member

@MoYuan-CN MoYuan-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原仓库的 LICENSE 副本和使用声明到哪里去了?

Copy link
Copy Markdown
Contributor

@Pigeon0v0 Pigeon0v0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

许可声明没加

@Hill23333
Copy link
Copy Markdown
Contributor Author

哦,忘了 明天加吧

@MoYuan-CN MoYuan-CN added 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Apr 12, 2025
@Hill23333
Copy link
Copy Markdown
Contributor Author

Hill23333 commented Apr 13, 2025

由于我发现了可能不需要引入第三方库的方法,所以转为 draft

Edit:
这种方法无法获取专辑封面,放弃

@Hill23333 Hill23333 marked this pull request as draft April 13, 2025 02:36
@Hill23333 Hill23333 marked this pull request as ready for review April 13, 2025 05:24
@Hill23333 Hill23333 added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🚧 正在处理 开发人员正在对该内容进行开发、测试或修复,进展中 labels Apr 13, 2025
@Hill23333 Hill23333 merged commit 9f7a9e6 into PCL-Community:dev Apr 13, 2025
5 checks passed
@Hill23333 Hill23333 added 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Apr 13, 2025
Comment on lines +329 to +340
If String.IsNullOrEmpty(Artist) Then
Artist = ""
End If
If String.IsNullOrEmpty(AlbumArtist) Then
AlbumArtist = Artist
End If
If String.IsNullOrEmpty(AlbumTitle) Then
AlbumTitle = ""
End If
If String.IsNullOrEmpty(Title) Then
Title = ""
End If
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If String.IsNullOrEmpty(Artist) Then
Artist = ""
End If
If String.IsNullOrEmpty(AlbumArtist) Then
AlbumArtist = Artist
End If
If String.IsNullOrEmpty(AlbumTitle) Then
AlbumTitle = ""
End If
If String.IsNullOrEmpty(Title) Then
Title = ""
End If
Artist = If(Artist, "")
AlbumArtist = If(String.IsNullOrEmpty(AlbumArtist), Artist, AlbumArtist)
AlbumTitle = If(AlbumTitle, "")
Title = If(Title, "")

@Hill23333 Hill23333 deleted the smtc-improve branch April 13, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants