Skip to content

Add the table's file name to the table_info string.#970

Merged
mauzey1 merged 2 commits into
PCMDI:mainfrom
mauzey1:964-table-name-in-table-info
May 13, 2026
Merged

Add the table's file name to the table_info string.#970
mauzey1 merged 2 commits into
PCMDI:mainfrom
mauzey1:964-table-name-in-table-info

Conversation

@mauzey1
Copy link
Copy Markdown
Collaborator

@mauzey1 mauzey1 commented May 13, 2026

Resolves #964

@mauzey1 mauzey1 requested a review from taylor13 May 13, 2026 01:55
Copy link
Copy Markdown
Collaborator

@taylor13 taylor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this write the full path or just the table name. I think to keep the global attribute listing less cluttered the filename would be sufficient, but if that's difficult, the full path would be acceptable. Just say so, and I'll "approve" instead of "Request changes". Thanks.

@mauzey1
Copy link
Copy Markdown
Collaborator Author

mauzey1 commented May 13, 2026

@taylor13 The "path" of a table is usually the file name of the table, which matches what you had in #964 (comment). I'm not sure if it ever includes other parts of the file path. Alternatively, I can use "szTable_id" so that it uses the table's table_id instead.

@taylor13
Copy link
Copy Markdown
Collaborator

Not concerned about how it's coded. If the table name will appear preferably without the directory path in front of it, that's ideal. Thanks.

@taylor13 taylor13 self-requested a review May 13, 2026 18:17
@taylor13
Copy link
Copy Markdown
Collaborator

I'm not sure how I can now officially approve, if that's needed. Let me know if I should do anything.
thanks,
Karl

@mauzey1
Copy link
Copy Markdown
Collaborator Author

mauzey1 commented May 13, 2026

@taylor13 I've updated the code so that it will just get the base name without any trailing path.

You can approve the pull request by going to "Files changed" tab, clicking on the "Submit review" button, and checking "Approve" and submitting the review.

Copy link
Copy Markdown
Collaborator

@taylor13 taylor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauzey1 mauzey1 merged commit e32e781 into PCMDI:main May 13, 2026
21 checks passed
@mauzey1 mauzey1 deleted the 964-table-name-in-table-info branch May 13, 2026 19:51
This was referenced May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we want to include "table_info" in files?

2 participants