Fix warning about signed/unsigned mismatch#649
Conversation
|
Thank you very much! Our windows CI builds don't have all the warnings enabled, unfortunately, so that's how this got past testing. There's an existing issue in my personal task list to tighten up on them. I'll let Zoltan review and merge, but the fix is fine to me. Adding "u" after the number constants would also work, if you wanted to avoid committing to a particular bit width. Merging to master is correct. Master is the new playground, open to all changes big and small, and I'll do the admin to cherry pick any fixes like this onto the final release branch when the time comes. (@zherczeg) |
|
Oh, I should have mentioned I already had an issue like this in the past, see #111. I used a cast because I did so in the previous PR, there already were a number of those in the file, and because |
Congrats on the RC1 🙂
I've got the following warning when trying to compile it with MSVC though, which is a problem when you turn warning as errors on:
(I supposed the PR should target the master branch)