Modernise FindReadline.cmake, and fix on Solaris #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
force-pushed
the
user/niwilson/termcap-fixes
branch
from
7301200 to
5c1df9f
Compare
NWilson
force-pushed
the
user/niwilson/termcap-fixes
branch
from
5c1df9f to
bc57c70
Compare
carenas
reviewed
Oct 7, 2025
carenas
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake build fails on Solaris out of the box, because our Autoconf has clever logic to add
-ltermcapas required by libreadline, but the CMake scripts just don't. And worse, CMake defaults to search for and link to all the third-party libraries, whereas Autoconf is set to not link them unless requested.