Skip to content

Use correctly-cased CMake variables for better compatibility #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2025
Merged

Use correctly-cased CMake variables for better compatibility #825

merged 2 commits into from
Oct 25, 2025

Conversation

@NWilson
Copy link
Member

@NWilson NWilson commented Oct 24, 2025 •
edited
Loading

  • Use the correct casing for <PackageName>_FOUND
  • Add a CI test with CMake very latest (currently 4.1.2). This job also sets DCMAKE_POLICY_VERSION_MINIMUM to verify that we don't break any future policies, greater than our minimum version 3.15.
  • Tidy the ncurses support for libreadline to use READLINE_LIBRARIES

Fixes #824

NWilson
NWilson commented Oct 24, 2025
View reviewed changes
@NWilson NWilson merged commit f8e7d12 into master Oct 25, 2025
37 of 38 checks passed
@NWilson NWilson deleted the user/niwilson/cmake-found-names branch October 25, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CMake dependencies _FOUND tests are wrong. CMake variables are case sensitive

2 participants

@NWilson