pcre2test: dynamically allocate buffer for JITTARGET #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
reviewed
Oct 29, 2025
carenas
force-pushed
the
riscy
branch
3 times, most recently
from
29ef209 to
e693142
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NWilson
reviewed
Oct 29, 2025
carenas
force-pushed
the
riscy
branch
2 times, most recently
from
86b2621 to
e1007ac
Compare
NWilson
approved these changes
Oct 30, 2025
carenas
commented
Oct 30, 2025
Contributor
Author
carenas
left a comment
carenas
left a comment
There was a problem hiding this comment.
needs squashing and a better commit message
| the Armv8.1 extension writes "ARM-64 (LSE) 64bit (little endian + unaligned)". | ||
| If JIT support is not available, PCRE2_ERROR_BADOPTION is returned, otherwise | ||
| the number of code units used is returned. This is the length of the string, | ||
| plus one code unit for the NUL character. |
Contributor
Author
There was a problem hiding this comment.
this is missing an historical overview and an explanation of why the use of static buffers is discouraged.
Member
There was a problem hiding this comment.
I'm happy with it. I can revise it in the next commit
…ARGET Always ask `pcre2_config()` for the expected size of buffers and abort if it is too small, effectively avoiding to do the validation after it was written. In preparation for deprecating the use of static buffers, increase the documented max size for JITTARGET to the next power of 2.
This was referenced Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only lightly tested, could be used as a basic "solution" for #831, that could be easily backported for 10.47.