Further updates to pcre2_config docs, and remove pcre2test's VERSION_SIZE #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
reviewed
Oct 31, 2025
doc/html/pcre2api.html
Outdated
| the PCRE2 version string, zero-terminated. The number of code units used is | ||
| returned. This is the length of the string plus one unit for the terminating | ||
| zero. | ||
| The <i>where</i> argument should point to a PCRE2_UCHAR-aligned buffer. All |
Contributor
There was a problem hiding this comment.
usually we spell out what is meant by sizeof(PCRE2_UCHAR) explicitly in the documentation by saying "the 16-nit and 32-bit" libraries require that the buffer be aligned to...
Member
Author
There was a problem hiding this comment.
Thank you. I have tweaked the wording
src/pcre2test_inc.h
Outdated
| size sizeof(where) or 0 to ask for the buffer to be allocated | ||
| Returns: the string where the data was written | ||
| Returns: a buffer which must be freed by the caller |
Contributor
There was a problem hiding this comment.
.. where the data was written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #835