pcre2test: allow using readline headers for libedit#99
Merged
PhilipHazel merged 1 commit intoPCRE2Project:masterfrom Apr 14, 2022
Merged
pcre2test: allow using readline headers for libedit#99PhilipHazel merged 1 commit intoPCRE2Project:masterfrom
PhilipHazel merged 1 commit intoPCRE2Project:masterfrom
Conversation
At least in OpenBSD, there is a libedit library in base, but without public headers. Public headers for readline are available but since 15db5d3 (pcre2test: avoid using readline headers with libedit, 2022-04-07) won't be picked up automatically. Allow pointing cmake to those headers by doing (for example): $ cmake -DEDITLINE_INCLUDE_DIR=/usr/include/readline Or using custom CPPFLAGS with configure (for example): $ CPPFLAGS=-I/usr/include/readline ./configure --enable-pcre2test-libedit Since the headers from readline.h would be otherwise incomplete, detect that case and pull the extra headers that are required automagically and while at it, cleanup the NCURSES dependency that was unnecessarily copied from readline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An addendum to #96, which brings back the posibility of using readline headers to link with libedit as that might be useful in at least OpenBSD.
Includes some tidy ups but nothing that would change functionality, except for the addition of a HAVE_READLINE_H macro by configure (when that override is triggered) which is currently not being used