Skip to content

Hot fix for file IO crash#52

Merged
Joseph-Ellaway merged 2 commits into
mainfrom
hot-fix
May 22, 2026
Merged

Hot fix for file IO crash#52
Joseph-Ellaway merged 2 commits into
mainfrom
hot-fix

Conversation

@Joseph-Ellaway
Copy link
Copy Markdown
Member

The new parser read a file on initialisation, not the parsing step. Was causing app to crash.

@Joseph-Ellaway Joseph-Ellaway requested a review from mihaitodor May 22, 2026 10:27
@Joseph-Ellaway Joseph-Ellaway self-assigned this May 22, 2026
Copilot AI review requested due to automatic review settings May 22, 2026 10:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hotfix to prevent a crash caused by reading the post-processing input file during parser initialization, by deferring file I/O until the parsing step.

Changes:

  • Bump package version from 3.2.0 to 3.2.1.
  • Move JSON file reading from PostProcessor.__init__ to PostProcessor.parse().
  • Update PostProcessComplexTable.parse() to call super().parse() before processing.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
uv.lock Updates locked editable package version to 3.2.1.
pyproject.toml Bumps project version to 3.2.1 for the hotfix release.
pisa_utils/post_process_parsers.py Defers input JSON reading until parse() to avoid initialization-time file I/O crashes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pisa_utils/post_process_parsers.py
Copy link
Copy Markdown
Contributor

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Joseph-Ellaway Joseph-Ellaway merged commit 5df3aad into main May 22, 2026
12 checks passed
@Joseph-Ellaway Joseph-Ellaway deleted the hot-fix branch May 22, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants