fix handling of prompt in OpenAI liked Translator#1065
Closed
soukouki wants to merge 1 commit intoPDFMathTranslate:mainfrom
Closed
fix handling of prompt in OpenAI liked Translator#1065soukouki wants to merge 1 commit intoPDFMathTranslate:mainfrom
soukouki wants to merge 1 commit intoPDFMathTranslate:mainfrom
Conversation
Collaborator
|
Thanks, will run a test first and merge later, given the priority of this improvement. |
reycn
added a commit
that referenced
this pull request
Mar 22, 2026
…lator Resolve conflict and apply fix from PR #1065 — prompt is now passed through super().__init__() instead of being set separately, consistent with how other translators handle it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Applied this fix directly to main in commit 8d990bb — prompt is now passed through super().init() in OpenAIlikedTranslator. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
self.prompttext = promptoperation is already handled by OpenAITranslator. To avoid redundant processing, I've modified OpenAILikedTranslator to include the prompt in thesuper().__init__call.