Skip to content

Conversation

@kad-korpem
Copy link
Collaborator

Description

In case a URL in the config contains env vars, these were escaped by url.Parse, causing potential issues later. To maintain the env vars, url.PathUnescape has been added to the marshalling methods.

Type of change

  • Bugfix

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@kad-korpem kad-korpem merged commit 6549cfc into master Jan 30, 2026
9 checks passed
@kad-korpem kad-korpem deleted the unescape-url-for-marshalling branch February 2, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants