Meme generator #13 #63
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/pages/activities/RandomMemes.js
Outdated
| <h1>Random Meme Generator</h1> | ||
| <div>Enter the name of Reddit community you want to get memes from.</div> | ||
| <div> Some examples are animememes, dankmemes, wholesomememes, etc. Submit empty box to get random memes</div> | ||
| <input className="rmeme-text" placeholder="Enter name of community here" id="text" type="text" onChange={GetName}></input> |
There was a problem hiding this comment.
use a more unique id than text, rest lgtm
Ishwarendra
left a comment
Ishwarendra
left a comment
There was a problem hiding this comment.
The input doesn't seem to work. I searched by writing chess but it still returned random meme not related to chess in any way
Also, there is CLS (Cumulative layout shift), on hovering submit button. You can take inspiration for button from Random Quote generator activity.
By CLS, I mean other |
Ok, will do so. Also, API used searches for memes from posts in Reddit communities. The community name for getting chess memes is r/chessmemes so putting chessmemes in the input box should work. Also, it produces related memes after clicking generate memes after clicking submit. Just after clicking submit it produces meme related to previous topic. To solve this what I can do is not generate any meme on clicking submit and generate meme only when clicking generate meme. |
Ishwarendra
left a comment
Ishwarendra
left a comment
There was a problem hiding this comment.
@GauravGupta993 While you are at the cls issue, write in small font about the example.
For example, if user has to type r/chessmemes then there should be a text For example: r/chessmemes will return chess memes, so that user knows what to type in the box.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
3 participants
#13 Solved.
Made a new PR because some conflicts were appearing due to which I had to discard the commit that closed the previous PR.