Feat: Add Random Anime Quote #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ken1000minus7
requested changes
Oct 7, 2024
Contributor
ken1000minus7
left a comment
ken1000minus7
left a comment
There was a problem hiding this comment.
Can you please revert all the unnecessary changes related to indentation and stuff? Those r not required 😅
Also there is a cors issue with the api call u r making so see if u can fix that
Comment on lines
13
to
29
| // const res = { | ||
| // status: "success", | ||
| // data: { | ||
| // content: "Whenever I counted on someone, I ended up getting hurt.", | ||
| // anime: { | ||
| // id: 2, | ||
| // name: "Hanasaku Iroha", | ||
| // }, | ||
| // character: { | ||
| // id: 5, | ||
| // name: "Ohana Matsumae", | ||
| // }, | ||
| // }, | ||
| // }; |
Contributor
There was a problem hiding this comment.
do not keep commented code, delete if not required
Contributor
|
Hey @Rahulagg13 , the received quote is being logged on the console but it is not being displayed, please fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Random Anime Quote Generator Feature
Description
This Pull Request introduces a new feature that allows users to generate random anime quotes, offering a fun way to receive inspirational or humorous quotes from various anime shows. The feature leverages the Animechan API to fetch random quotes.
Changes:
RandomAnimeQuotethat fetches and displays a random anime quote.axiosfor handling API requests.activitieslist to add the "Random Anime Quote" option with relevant icon and URL.RandomAnimeQuotecomponent with basic CSS for proper layout.Related Issue:
This PR addresses the issue: #85