fix: preserve custom geofence names when toggling predefined areas#113
Merged
hokiepokedad2 merged 2 commits intomainfrom Apr 4, 2026
Merged
fix: preserve custom geofence names when toggling predefined areas#113hokiepokedad2 merged 2 commits intomainfrom
hokiepokedad2 merged 2 commits intomainfrom
Conversation
syncSelectedFromAreas() was overwriting selectedAreas with only predefined area names, silently dropping custom geofence kojiNames. When the user then saved, those geofences were removed from their area list, requiring navigation back to the geofences page to re-activate them. Now preserves custom geofence names (not in the predefined areas list) across checkbox toggles, matching the preservation logic already used in saveAreas(). Closes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncSelectedFromAreas()in the Areas page was overwritingselectedAreaswith only predefined area names on every checkbox toggle, silently dropping custom geofencekojiNameentriessaveAreas()area-list.component.ts— the same patternsaveAreas()already uses at lines 264-270Bug scenario (before fix)
syncSelectedFromAreas()fires, overwritesselectedAreasto only predefined names — "my_park" is lostAfter fix
Custom geofence names are preserved through checkbox toggles and included in the save payload.
Closes #109
Test plan