feat: add Max Battles quick pick support#143
Merged
Merged
Conversation
Add maxbattle alarm type to the Quick Pick system so admins can create pre-configured Max Battle alarm templates for users. Backend: - Add IMaxBattleService injection to QuickPickService - Add maxbattle case to ApplyAsync, RemoveAsync, CountRemainingUidsAsync, GetValidUidsAsync - ApplyMaxBattleAsync creates 7 alarms (levels 1-5 gmax=0, 7-8 gmax=1) when pokemon_id=9000 and level=9000 (all-levels mode) - BuildMaxBattle helper follows existing BuildRaid pattern Frontend: - Add maxbattle to alarm type dropdown in admin quick pick dialog - Add Max Battles category option - Add maxbattle form fields (pokemonId, level, gmax, form, move, evolution) - Add maxbattle color to quick pick list component Tests: - Update QuickPickServiceSecurityTests constructor with IMaxBattleService mock Closes #140
hokiepokedad2
force-pushed
the
feature/140-maxbattle-quick-picks
branch
from
acc448f to
704300a
Compare
Contributor
Author
Code Review: PR !143 — Max Battles Quick Pick SupportGrade: A (Approved)
Changes (6 files, +120/-3)
Verdict: APPROVEDClean, minimal implementation following existing patterns exactly. No issues found. |
hokiepokedad2
added a commit
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
maxbattlealarm type to the Quick Pick system. Closes #140.QuickPickServicegainsIMaxBattleServiceinjection andmaxbattlecases in Apply/Remove/Count/GetValid switches.ApplyMaxBattleAsynccreates 7 alarms (levels 1-5 with gmax=0, levels 7-8 with gmax=1) when all-levels mode is used.maxbattlealarm type option,Max Battlescategory, and form fields. List component gets color mapping.QuickPickServiceSecurityTestsupdated withIMaxBattleServicemock.Test plan
dotnet build— 0 errorsdotnet test— 621 passedng build --production— successnpm run lint— warnings onlynpx jest— 487 passed