fix: raid alarm card shows 9000 stars for level 9000#144
Merged
Conversation
Guard getLevelStars() to return empty array when level is 9000 (any) or unreasonably large. Show "Any Level" italic text instead of stars for both raid and egg cards. Also fix egg card title to show "Any Level Egg" instead of "Level 9000 Egg". Closes #138
Also fix egg delete confirmation to show 'Any Level' instead of 'Level 9000' for the sentinel value.
Add getRaidLevelName() helper that maps level numbers to labels: - Level 6 → "Mega" - Level 9000 → "Any Level" - Others → "Level N" Used in raid titles, egg titles, and delete confirmations.
PoracleNG treats pokemon_id=0 as the "everything" sentinel and
overrides all other filters (level, evolution, etc.) to 9000. This
caused level-based quick picks like "All Mega Raids" (level=6) to
create alarms with level=9000 instead.
Use pokemon_id=9000 ("any pokemon") which preserves the level filter
while still matching all raid bosses.
Contributor
Author
Code Review: PR !144 — Fix raid 9000 starsGrade: A (Approved)
Commits (4)
Key findingPoracleNG treats `pokemon_id=0` as the "everything" sentinel, overriding all other fields to 9000. The "All Mega Raids" quick pick was sending `pokemon_id=0, level=6` which PoracleNG normalized to `level=9000`. Fix: use `pokemon_id=9000` ("any pokemon") which preserves the level filter. Verdict: APPROVED |
hokiepokedad2
added a commit
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes raid and egg alarm cards rendering 9000 star icons when level is set to 9000 (the "any level" sentinel). Closes #138.
getLevelStars()to return empty array for level 9000 or > 100Test plan
ng build --production— successnpm run lint— warnings onlynpx jest— 487 passed