feat: Profile active hours / schedule management UI

[hokiepokedad2]

Summary

Closes #158

• Add UI to view and edit active_hours on user profiles — PoracleNG's profile scheduler uses these rules to automatically switch profiles at configured times
• Thread active_hours through the existing proxy pipeline (backend model, deserialization, create/update/duplicate payloads)
• Server-side validation: day 1-7, hours 0-23, mins 0-59, max 28 entries
• Warn when a profile has active hours but 0,0 coordinates (causes PoracleNG to fall back to UTC for timezone, triggering switches at wrong times)

New components

• ActiveHoursChipComponent — compact amber schedule pills on profile cards (e.g., "Weekdays 9:00 AM")
• ActiveHoursEditorDialogComponent — circular day picker with presets, time picker, grouped rules list, mini weekly preview grid
• LocationWarningComponent — inline red warning for the 0,0 coordinates timezone bug

Cleanup

• Removed unused ProfileListComponent (was never routed — /profiles loads ProfileOverviewComponent)

Test plan

• Backend builds with 0 errors
• 764 backend tests pass (17 new validation tests + extended profile controller/service tests)
• 55 frontend test suites, 561 tests pass (new specs for all components + utilities)
• Docker image builds and container starts successfully
• Verify schedule chips display correctly for users with active hours (e.g., Andrew's profiles)
• Verify editor dialog opens, adds/removes rules, saves to PoracleNG
• Verify location warning appears on profiles with 0,0 coords + active hours
• Verify "Manual only" displays for profiles without active hours

[hokiepokedad2]

Code Review: PR #159

Overall: ✅ APPROVED

Metric	Rating
Code Quality	Good
Requirements	All from #158 satisfied
Architecture Fit	Excellent — follows proxy-first pattern, standalone Angular components
Risk Level	Low — additive only, no DB migrations

Findings Summary

1 Critical (Fixed): Double type-cast as unknown as string in profile.service.ts:34 — replaced with runtime typeof check in dc1924b.

4 Minor/Informational:

• parseActiveHoursField() wrapper in profile-overview is redundant (could bind parseActiveHours directly)
• Profile.activeHours type annotation could use JSDoc clarifying the parse pipeline
• No client-side range validation in addEntries() (server validates, but defense-in-depth would be nice)
• Missing string-coercion test case — added in dc1924b (2 new tests, 563 total)

Architecture Highlights

• ✅ Zero proxy changes — active_hours flows through existing JsonElement pass-through
• ✅ No DB migration — PoracleNG owns the column
• ✅ Server-side validation: day 1-7, hours 0-23, mins 0-59, max 28 entries, handles string/int types
• ✅ String→number coercion for PoracleNG compatibility (stores "09" not 9)
• ✅ Comprehensive tests: 764 backend + 563 frontend, all passing

Test Coverage

• 17 new backend validation tests (ActiveHoursValidationTests)
• 4 new controller tests + 3 service tests
• 43 frontend tests across 5 new spec files
• ESLint clean, Prettier clean

Post-Merge Recommendations

• Take UI screenshots for docs (schedule chips, editor dialog)
• Verify with a real user who has active hours (e.g., Andrew's profiles)
• Consider adding client-side validation in editor dialog for defense-in-depth

Full review report: PR_159_Code_Review_Report.md

[hokiepokedad2]

Code Review: Round 2 — All Issues Resolved ✅

Issues Fixed in 8cd594f

#	Issue	Fix
1	Redundant parseActiveHoursField() wrapper	Replaced with readonly parseActiveHours = parseActiveHours class property
2	No client-side validation in addEntries()	Added h < 0 || h > 23 || m < 0 || m > 59 guard
3	No whitespace trimming in ValidateActiveHours	Changed to IsNullOrWhiteSpace + Trim()
4	day field rejects strings but hours/mins accept them	Changed to TryGetIntValue for consistency
5	Missing negative number tests	Added: -1 hours, -5 mins, -1 day
6	Missing edge case tests	Added: float hours (9.5), boolean hours, extremely large (999999), whitespace, string day
7	Missing duplicate-with-active-hours test	Added: verifies active_hours in proxy payload
8	Missing negative-coords location warning test	Added: southern hemisphere coords test
9	ESLint sort-classes warning	Auto-fixed property ordering

Final Test Results

Suite	Result
Backend	774 passed, 0 failed (+10 new validation tests, +1 controller test)
Frontend	564 passed, 0 failed (+1 location warning test)
ESLint	Clean (0 errors, 0 warnings)
.NET Build	0 errors

Verdict: ✅ APPROVED — No remaining issues

All findings from round 1 have been addressed. The PR is ready to merge.

[hokiepokedad2]

Code Review: Round 3 (Fresh Full Review) — ✅ APPROVED

Issues Found and Fixed in e13e934

#	Severity	Issue	Fix
1	Major	updateActiveHours sends null name to proxy, potentially blanking profile name	Backend Update now merges with existing: name = profile.Name ?? existing.Name, active_hours = profile.ActiveHours ?? existing.ActiveHours
2	Major	Duplicate [2.2.0] header in CHANGELOG.md	Removed duplicate line
3	Minor	Test file active-hours.utils.spec.ts in wrong directory (tests functions from core/models/)	Moved to core/models/active-hours.models.spec.ts next to source

Remaining Minor Notes (Not Blocking)

• Hardcoded amber colors in SCSS — acceptable design choice, could be extracted to CSS vars later
• DAY_LETTERS has duplicate T/S values — tooltips use DAY_LABELS on the day buttons, so this is fine
• updateActiveHours returns Observable<void> but backend returns Profile — harmless since caller reloads

Positive Findings

• Robust server-side validation with 28 test cases covering all edge cases
• Clean signal-based Angular architecture
• Correct PoracleNG string coercion on both frontend and backend
• Proper field merging prevents partial updates from blanking data
• Duplicate entries correctly deduplicated in editor dialog
• Dark theme support on all new components
• 774 backend + 564 frontend tests, all passing

Final Test Results

Suite	Result
Backend	774 passed, 0 failed
Frontend	564 passed, 0 failed (55 suites)
ESLint	0 errors, 0 warnings
.NET Build	0 errors

Verdict: ✅ APPROVED — Ready to merge