Skip to content

Conversation

@nicolasaunai
Copy link
Member

@nicolasaunai nicolasaunai commented Feb 13, 2025

This adds the doxygen configuration for generating developer's documentation.
I'm not sure we want the doxygen html outputs generated somewhere (where? how automatically?) or we want to use breathe extention to sphinx to couple our sphinx documentation published on readthedoc to doxygen comments in our code.
TBD together

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2025

📝 Walkthrough

Walkthrough

A Doxygen configuration file and related documentation updates were introduced. The Sphinx documentation system was modified to support Markdown files by adding the myst-parser extension and updating configuration. The Makefile now includes targets for cleaning and generating Doxygen documentation. A new developer documentation section and a Markdown parser dependency were also added.

Changes

File(s) Change Summary
doc/Doxyfile.in Added a comprehensive Doxygen configuration file for generating project documentation with detailed settings.
doc/Makefile Added clean and Doxygen-build targets for cleaning build artifacts and generating Doxygen documentation.
doc/doxypages/main.md Added a new "Developer documentation" section with a brief introductory statement.
doc/source/conf.py Enabled Markdown support in Sphinx by adding myst_parser and updating source_suffix to include .md files.
doc/source/requirements.txt Added the myst-parser dependency for Markdown support in Sphinx documentation.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Makefile
    participant Doxygen
    participant Sphinx

    Developer->>Makefile: make Doxygen-build
    Makefile->>Doxygen: Run with doc/Doxyfile.in
    Doxygen-->>Developer: Generate documentation

    Developer->>Makefile: make clean
    Makefile->>Sphinx: sphinx-build -M clean
    Sphinx-->>Developer: Clean build artifacts

    Developer->>Sphinx: Build docs (now supports .md with myst-parser)
    Sphinx->>myst-parser: Parse Markdown files
    Sphinx-->>Developer: Generate documentation (from .rst and .md)
Loading

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
doc/Makefile (1)

25-26: Enhance the Doxygen-build target.

Consider adding error handling and making the target phony.

+.PHONY: help Makefile clean Doxygen-build
+
 Doxygen-build:
-	doxygen Doxyfile
+	@command -v doxygen >/dev/null 2>&1 || { echo >&2 "doxygen not found. Please install it."; exit 1; }
+	@doxygen Doxyfile || { echo >&2 "Doxygen documentation generation failed"; exit 1; }
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce77d6b and 8a075b2.

📒 Files selected for processing (5)
  • doc/Doxyfile.in (1 hunks)
  • doc/Makefile (1 hunks)
  • doc/doxypages/main.md (1 hunks)
  • doc/source/conf.py (2 hunks)
  • doc/source/requirements.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • doc/source/requirements.txt
🧰 Additional context used
🪛 LanguageTool
doc/doxypages/main.md

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (macos-14)
  • GitHub Check: Analyze (cpp)
  • GitHub Check: build (macos-13)
  • GitHub Check: build (ubuntu-latest)
🔇 Additional comments (1)
doc/source/conf.py (1)

53-53: LGTM! Good addition of Markdown support.

The addition of the myst_parser extension and .md file support enhances documentation capabilities by allowing both reStructuredText and Markdown files.

Also applies to: 87-88

@nicolasaunai
Copy link
Member Author

limits sphinx version, see #955

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

♻️ Duplicate comments (1)
doc/doxypages/main.md (1)

4-4: Fix grammatical typo in the sentence.

The word “were” should be “where” in this context.

Apply this diff:

-This is were all dark secrets are revealed.
+This is where all dark secrets are revealed.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

🧹 Nitpick comments (12)
doc/doxypages/main.md (1)

4-4: Replace placeholder text with a meaningful introduction.

Rather than a humorous placeholder, provide a concise description of what the developer documentation covers (e.g., API references, code structure, build and Doxygen integration).

🧰 Tools
🪛 LanguageTool

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

doc/source/theory/amr.md (2)

3-3: Use a hyphen in the compound adjective.

“Patch based approach” should be “Patch-based approach.”

🧰 Tools
🪛 LanguageTool

[uncategorized] ~3-~3: This expression is usually spelled with a hyphen.
Context: # Adaptive Mesh Refinement ## Patch based approach ## Recursive time integration...

(BASED_HYPHEN)


1-16: Populate each section with content.

Every heading currently stands alone. Add a brief overview or description under each (e.g., outline algorithms in “Recursive time integration” or criteria in “Field coarsening”) to make the document informative.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~3-~3: This expression is usually spelled with a hyphen.
Context: # Adaptive Mesh Refinement ## Patch based approach ## Recursive time integration...

(BASED_HYPHEN)

doc/source/pharesee/get_data.md (2)

14-14: Correct the import sentence for clarity.

Update to a more natural phrasing:

-Then import the [pharesee]{.title-ref} package should work:
+The [pharesee]{.title-ref} package can then be imported as follows:
🧰 Tools
🪛 LanguageTool

[uncategorized] ~14-~14: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ONPATH:/path/to/PHARE/pyphare ``` Then import the [pharesee]{.title-ref} package shou...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


22-23: Add missing comma in compound sentence.

Separate the independent clauses:

-…have been activated and you want to get the magnetic field.
+…have been activated, and you want to get the magnetic field.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~23-~23: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...nostics]{.title-ref} have been activated and you want to get the magnetic field. Ass...

(COMMA_COMPOUND_SENTENCE)

doc/source/theory/pic.md (2)

6-7: Fix subject–verb agreement and improve wording.

Change “require lots of” to “requires significant”:

-It is generally complex and require lots of computational resources.
+It is generally complex and requires significant computational resources.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~7-~7: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...rid code". It is generally complex and require lots of computational resources. The ot...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


[style] ~7-~7: Consider using a synonym to be more concise.
Context: ...". It is generally complex and require lots of computational resources. The other way ...

(A_LOT_OF)


27-28: Insert missing comma for readability.

Add a comma after “order”:

-The higher the order the further a macro-particle influences the distribution, but the longer it takes to compute it.
+The higher the order, the further a macro-particle influences the distribution, but the longer it takes to compute it.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~28-~28: A comma might be missing here.
Context: ... second and third order. The higher the order the further a macro-particle influences...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)

doc/source/index.md (1)

17-17: Simplify wording for conciseness.

Use “incomplete” instead of “not complete”:

-Warning: This documentation is a work in progress. It is not complete and may contain errors.
+Warning: This documentation is a work in progress. It is incomplete and may contain errors.
🧰 Tools
🪛 LanguageTool

[style] ~17-~17: Consider using “incomplete” to avoid wordiness.
Context: ...umentation is a work in progress. It is not complete and may contain errors. ```{=html} <st...

(NOT_ABLE_PREMIUM)

doc/source/usage/run_from_python.md (1)

12-14: Code fence language identifier
Remove the extra space in the fenced code block header. Use “bash” instead of “ bash” for consistency with Markdown conventions.

doc/source/theory/hybridpic.md (3)

37-44: Improve punctuation and clarity
In the electron fluid paragraph, add commas for readability. E.g.:
“This is wrong, of course, in collisionless systems, since nothing makes…”

🧰 Tools
🪛 LanguageTool

[uncategorized] ~37-~37: A comma might be missing here.
Context: ...e assumed to behave as a fluid. This is wrong of course in collisionless systems sinc...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[uncategorized] ~37-~37: A comma might be missing here.
Context: ... to behave as a fluid. This is wrong of course in collisionless systems since nothing ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


82-82: Verb agreement
In “Quasineutrality enable us…”, change “enable” to “enables.”

🧰 Tools
🪛 LanguageTool

[uncategorized] ~82-~82: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...ready, that's our $n$. Quasineutrality enable us to get the electron bulk velocity fr...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


107-107: Typo: “than” vs “that”
Replace “longer that the scales” with “longer than the scales.”

🧰 Tools
🪛 LanguageTool

[uncategorized] ~107-~107: “that” seems less likely than “than” (as in: greater than).
Context: ...nterested in are much larger and longer that the scales at which the electron bulk i...

(AI_HYDRA_LEO_CP_THAT_THAN)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3d5fe02 and ad33dc8.

📒 Files selected for processing (37)
  • doc/Doxyfile.in (1 hunks)
  • doc/Makefile (1 hunks)
  • doc/doxypages/main.md (1 hunks)
  • doc/source/build.md (1 hunks)
  • doc/source/build.rst (0 hunks)
  • doc/source/conf.py (2 hunks)
  • doc/source/getting.md (1 hunks)
  • doc/source/getting.rst (0 hunks)
  • doc/source/index.md (1 hunks)
  • doc/source/index.rst (0 hunks)
  • doc/source/pharesee/get_data.md (1 hunks)
  • doc/source/pharesee/get_data.rst (0 hunks)
  • doc/source/pharesee/plotting_distributions.md (1 hunks)
  • doc/source/pharesee/plotting_distributions.rst (0 hunks)
  • doc/source/pharesee/plotting_fields.md (1 hunks)
  • doc/source/pharesee/plotting_fields.rst (0 hunks)
  • doc/source/requirements.txt (1 hunks)
  • doc/source/theory/amr.md (1 hunks)
  • doc/source/theory/amr.rst (0 hunks)
  • doc/source/theory/hybridpic.md (1 hunks)
  • doc/source/theory/hybridpic.rst (0 hunks)
  • doc/source/theory/pic.md (1 hunks)
  • doc/source/theory/pic.rst (0 hunks)
  • doc/source/theory/spatial_discretization.md (1 hunks)
  • doc/source/theory/spatial_discretization.rst (0 hunks)
  • doc/source/theory/temporal_discretization.md (1 hunks)
  • doc/source/theory/temporal_discretization.rst (0 hunks)
  • doc/source/usage/examples.md (1 hunks)
  • doc/source/usage/examples.rst (0 hunks)
  • doc/source/usage/maxwellian_fluid_model.md (1 hunks)
  • doc/source/usage/maxwellian_fluid_model.rst (0 hunks)
  • doc/source/usage/run_from_exe.md (1 hunks)
  • doc/source/usage/run_from_exe.rst (0 hunks)
  • doc/source/usage/run_from_python.md (1 hunks)
  • doc/source/usage/run_from_python.rst (0 hunks)
  • doc/source/usage/simulation_inputs.md (1 hunks)
  • doc/source/usage/simulation_inputs.rst (0 hunks)
💤 Files with no reviewable changes (16)
  • doc/source/usage/examples.rst
  • doc/source/theory/spatial_discretization.rst
  • doc/source/theory/temporal_discretization.rst
  • doc/source/pharesee/plotting_distributions.rst
  • doc/source/pharesee/plotting_fields.rst
  • doc/source/usage/maxwellian_fluid_model.rst
  • doc/source/usage/run_from_exe.rst
  • doc/source/getting.rst
  • doc/source/theory/amr.rst
  • doc/source/build.rst
  • doc/source/index.rst
  • doc/source/theory/pic.rst
  • doc/source/usage/run_from_python.rst
  • doc/source/usage/simulation_inputs.rst
  • doc/source/pharesee/get_data.rst
  • doc/source/theory/hybridpic.rst
✅ Files skipped from review due to trivial changes (10)
  • doc/source/usage/examples.md
  • doc/source/theory/temporal_discretization.md
  • doc/source/theory/spatial_discretization.md
  • doc/source/pharesee/plotting_distributions.md
  • doc/source/pharesee/plotting_fields.md
  • doc/source/usage/maxwellian_fluid_model.md
  • doc/source/usage/run_from_exe.md
  • doc/source/getting.md
  • doc/Doxyfile.in
  • doc/source/build.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • doc/source/requirements.txt
  • doc/Makefile
  • doc/source/conf.py
🧰 Additional context used
🪛 LanguageTool
doc/doxypages/main.md

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

doc/source/index.md

[uncategorized] ~2-~2: Loose punctuation mark.
Context: orphan : # PHARE PHARE is a Hybrid Particle...

(UNLIKELY_OPENING_PUNCTUATION)


[style] ~17-~17: Consider using “incomplete” to avoid wordiness.
Context: ...umentation is a work in progress. It is not complete and may contain errors. ```{=html} <st...

(NOT_ABLE_PREMIUM)

doc/source/pharesee/get_data.md

[uncategorized] ~14-~14: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ONPATH:/path/to/PHARE/pyphare ``` Then import the [pharesee]{.title-ref} package shou...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


[uncategorized] ~23-~23: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...nostics]{.title-ref} have been activated and you want to get the magnetic field. Ass...

(COMMA_COMPOUND_SENTENCE)

doc/source/theory/amr.md

[uncategorized] ~3-~3: This expression is usually spelled with a hyphen.
Context: # Adaptive Mesh Refinement ## Patch based approach ## Recursive time integration...

(BASED_HYPHEN)

doc/source/theory/hybridpic.md

[uncategorized] ~37-~37: A comma might be missing here.
Context: ...e assumed to behave as a fluid. This is wrong of course in collisionless systems sinc...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[uncategorized] ~37-~37: A comma might be missing here.
Context: ... to behave as a fluid. This is wrong of course in collisionless systems since nothing ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[typographical] ~53-~53: It seems that a comma is missing.
Context: ...o the Vlasov equation we used for ions. Well not really... But let's say we did. N...

(WELL_COMMA)


[uncategorized] ~65-~65: A comma may be missing after the conjunctive/linking adverb ‘Instead’.
Context: ...to get the new electron fluid momentum. Instead we make assumptions on the electron flu...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)


[uncategorized] ~70-~70: A punctuation mark might be missing here.
Context: ... +\frac{m_e}{e}\frac{d\mathbf{u_e}}{dt} \label{eq:ohmelectron} \end{equation}$$ ...

(AI_EN_LECTOR_MISSING_PUNCTUATION)


[uncategorized] ~82-~82: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...ready, that's our $n$. Quasineutrality enable us to get the electron bulk velocity fr...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


[uncategorized] ~107-~107: “that” seems less likely than “than” (as in: greater than).
Context: ...nterested in are much larger and longer that the scales at which the electron bulk i...

(AI_HYDRA_LEO_CP_THAT_THAN)


[uncategorized] ~108-~108: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...a matters. The electrons being so light compare to even protons, that it is mostly ok t...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


[uncategorized] ~123-~123: You might be missing the article “an” here.
Context: ...here is no rigorous way of getting such equation and most hybrid code assume a closure t...

(AI_EN_LECTOR_MISSING_DETERMINER_AN)


[uncategorized] ~123-~123: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...f getting such equation and most hybrid code assume a closure that is "reasonable"...

(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)


[uncategorized] ~124-~124: A comma might be missing here.
Context: ...losure that is "reasonable" and above all "simple" to calculate. Perhaps the s...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[uncategorized] ~127-~127: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...sure is the isothermal one. This simply say that the electron pressure $P_e$ is giv...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


[uncategorized] ~138-~138: You might be missing the article “the” here.
Context: ...quation}$$ ## Dissipative terms Using above equations to calculate the electric fie...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~139-~139: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...ic field would result in current sheets to collapse at grid scale in the absence of an intr...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


[uncategorized] ~141-~141: Possible missing comma found.
Context: ...es to include such a dissipation. Joule resistivity well known to be used already in MHD co...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~143-~143: Did you mean the adjective “right-hand”?
Context: ...le term $\eta \mathbf{j}$ to add on the right hand side of the electric field equation. Th...

(MISSING_HYPHEN)


[uncategorized] ~144-~144: A comma may be missing after the conjunctive/linking adverb ‘However’.
Context: ...s term adds diffusion of magnetic flux. However there is no scale at which this terms d...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)


[uncategorized] ~144-~144: The determiner “these” seems more likely in this context.
Context: ...lux. However there is no scale at which this terms dominate over the electron ideal ...

(AI_EN_LECTOR_REPLACEMENT_DETERMINER)


[uncategorized] ~156-~156: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... adds sub-ion scale dissipation. PHARE include these two terms and the electric field ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


[uncategorized] ~156-~156: Possible missing comma found.
Context: ...e dissipation. PHARE include these two terms and the electric field is obtained via ...

(AI_HYDRA_LEO_MISSING_COMMA)

doc/source/theory/pic.md

[uncategorized] ~7-~7: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...rid code". It is generally complex and require lots of computational resources. The ot...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)


[style] ~7-~7: Consider using a synonym to be more concise.
Context: ...". It is generally complex and require lots of computational resources. The other way ...

(A_LOT_OF)


[uncategorized] ~28-~28: A comma might be missing here.
Context: ... second and third order. The higher the order the further a macro-particle influences...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)

doc/source/usage/run_from_python.md

[uncategorized] ~9-~9: You might be missing the article “the” here.
Context: ...thon package dependencies are listed in [requirements.txt]{.title-ref} file. Inst...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~26-~26: You might be missing the article “the” here.
Context: ...re it is accessible to python. Assuming PHARE source directory is in [/path/to/PHARE]...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

doc/source/usage/simulation_inputs.md

[grammar] ~77-~77: Did you mean “setting”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...ion for each population. It also allows to set the magnetic field profile. Below is a...

(ALLOW_TO)


[uncategorized] ~151-~151: Did you mean “cell”? If following ‘per’, nouns are often singular.
Context: ...lation is added with more particles per cells and different moments.: ``` python ph....

(CONFUSION_OF_NNS_NN_UN)


[formatting] ~151-~151: These punctuation marks differ from each other. Use only one if you are ending a sentence.
Context: ...articles per cells and different moments.: ``` python ph.MaxwellianFluidModel( ...

(DOUBLE_PUNCTUATION_PREMIUM)


[uncategorized] ~255-~255: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...ocity of the ions - pressure_tensory: represent the total pressure tensor of the ions ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

🪛 markdownlint-cli2 (0.17.2)
doc/source/usage/simulation_inputs.md

248-248: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)


257-257: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)

⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Analyze (cpp)
  • GitHub Check: build (ubuntu-latest, gcc)
  • GitHub Check: build (ubuntu-latest, clang)
  • GitHub Check: build (macos-13)
  • GitHub Check: build (macos-14)
  • GitHub Check: build (macos-latest)
  • GitHub Check: Analyze (python)
🔇 Additional comments (4)
doc/source/index.md (1)

1-3: Verify or correct the ‘orphan’ directive usage.

A standalone “orphan” (and lone colon) isn’t valid MyST Markdown. Confirm its intent: if it’s meant as metadata, convert to YAML front-matter or a proper directive; otherwise, remove it.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~2-~2: Loose punctuation mark.
Context: orphan : # PHARE PHARE is a Hybrid Particle...

(UNLIKELY_OPENING_PUNCTUATION)

doc/source/usage/run_from_python.md (1)

82-84: Verify autodoc directive syntax
The directive ::: {.autoclass members=""} may not be recognized by myst-parser. Confirm whether it should instead be:

::: autoclass:: pyphare.simulator.simulator.Simulator
    :members:

to properly generate class documentation.

doc/source/usage/simulation_inputs.md (1)

67-69: Verify autodoc directive syntax
The ::: autoclass block is missing the proper directive syntax. It should likely read:

::: autoclass:: pyphare.pharein.Simulation
    :members:

Please confirm and adjust to ensure Sphinx/myst-parser picks it up.

doc/source/theory/hybridpic.md (1)

158-161: Validate equation labels
Ensure that labels like eq:ohmelectron4 are correctly referenced and supported by Sphinx’s math directives.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
doc/doxypages/main.md (1)

4-4: Fix grammatical error flagged in past review.
Please replace "were" with "where":

- This is were all dark secrets are revealed.
+ This is where all dark secrets are revealed.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

🧹 Nitpick comments (1)
doc/doxypages/main.md (1)

4-4: Expand the developer documentation content.
The current placeholder text is too informal and doesn’t explain how to generate or contribute to the docs. Consider adding:

  • An overview of doc/Doxyfile.in and how to customize the output directory for HTML
  • Instructions to run make Doxygen-build (in doc/Makefile) and where the generated files appear
  • Steps to integrate Doxygen output into Sphinx via the breathe extension
  • Prerequisites and version constraints (Doxygen, Sphinx, Python packages)
🧰 Tools
🪛 LanguageTool

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad33dc8 and 418914a.

📒 Files selected for processing (5)
  • doc/Doxyfile.in (1 hunks)
  • doc/Makefile (1 hunks)
  • doc/doxypages/main.md (1 hunks)
  • doc/source/conf.py (2 hunks)
  • doc/source/requirements.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • doc/Doxyfile.in
🚧 Files skipped from review as they are similar to previous changes (3)
  • doc/source/requirements.txt
  • doc/Makefile
  • doc/source/conf.py
🧰 Additional context used
🪛 LanguageTool
doc/doxypages/main.md

[uncategorized] ~4-~4: “were” seems less likely than “where”.
Context: # Developer documentation This is were all dark secrets are revealed.

(AI_HYDRA_LEO_CPT_WERE_WHERE)

⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Analyze (cpp)
  • GitHub Check: Analyze (python)
  • GitHub Check: build (ubuntu-latest, clang)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (macos-14)
  • GitHub Check: build (macos-13)
  • GitHub Check: build (ubuntu-latest, gcc)
🔇 Additional comments (1)
doc/doxypages/main.md (1)

2-2: Heading is clear and appropriately formatted.
No changes needed here.

@nicolasaunai nicolasaunai marked this pull request as ready for review May 28, 2025 08:28
@nicolasaunai nicolasaunai merged commit e2bc1ac into PHAREHUB:master May 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants