Feat: Better barfile selection in bar2vtk#23
Merged
Conversation
- Glob string was not strict enough to prevent false positives - Added file in example to serve as a "test"
- Allow for explicit assignment of the velbar and stsbar files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous glob string wasn't strict enough, so it needed replacing.
While at it, I added the
--velbarand--stsbarflags tobar2vtkto allow for explicit selection of the paths to each respective files. They also allow for two files to be given in the case of creating split time windows.