Conversation
- The actual computation and argument parsing for bar2vtk has been split
- Moved all the argparse code to a separate function
- Note: this commit was created after many other changes. Thus the commit might not be completely stand alone
- Also moved bar2vtk script functionality into bar2vtk_bin - Renamed bar2vtk to bar2vtk_function
- Could not manage to get using `bar2vtk toml blank` to work simultaneously with `bar2vtk toml` - Functionality replaced with -b/--blank flag
- Have tomlReceipt keep the vtmPath metadata - Rename the vtk.VTK_VERSION toml key to be consistent with other version keys
- Change error messages that reference command flags to instead just reference the argument name: "--velbar" => "velbar"
- Can read arguments from toml file - Converts arguments to correct type
- With move to toml, the name of positional arguments matters significantly more
jrwrigh
force-pushed
the
feat/bar2vtk-toml
branch
from
97fb3e9 to
d971c91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
tomldocuments as configuration files forbar2vtkand as "receipt" files to keep track of how a file was created. Todo:Receipt should contain:
bar2vtkinput argumentsGeneral toml functionality
Closes #34