FIX: Read velocities from file in r.terabin#124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 42 42
Lines 5783 5788 +5
=======================================
+ Hits 5295 5300 +5
Misses 488 488
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| ABIN_CMD="$ABIN_CMD -M $TC_PORT" | ||
| fi | ||
| if [[ -z $VELOC_IN ]];then | ||
| if [[ -n $VELOC_IN ]];then |
There was a problem hiding this comment.
This is the fix. :-(
There was a problem hiding this comment.
Ugh, ok not great, but I think a) most of the people were not going to the $PHOTOX for the script b) tera was kinda underused for the last few years. Nevertheless, we should consider making ABIN 1.1 default for the older clusters to catch this error.
There was a problem hiding this comment.
Yes, for sure. I am basically done with the refactorings and testing. I need to fix some issues with restart (especially for SH). I wil then run a set of SH calculations for Basile's PCCP test systems and the we should release version 1.2
danielhollas
force-pushed
the
fix-vel-terabin
branch
from
b1b5f27 to
a2fd601
Compare
|
@danielhollas can confirm that your fix works as intended, thanks a lot! Let's just hope this bug doesn't affect too many people. |
| mv ERROR ABIN_ERROR4 | ||
|
|
||
| $ABINEXE -M >> abin.out 2>&1 || true | ||
| mv ERROR ABIN_ERROR5 |
3 participants
Unfortunately,
r.terabinhas been broken since Dec 2019 since this commit:42eec0b#diff-9be526330a9213578d1f49c8c02341eb1a4474cd3aa8de81cda0a1051417f7d0R128
It would ignore the velocity file specified at the top in variable
$VELOC_IN.@suchanj I am not sure how much is this script used and how much are people reading velocities from a file...
This bug would should have been caught earlier, since for simulations without velocity file we were executing ABIN lwith an empty
-vlike this:Unfortunately, due to the way we were parsing the command line, this was interpreted as an empty string, and because the default for the velocity file name is an empty string, this was a valid invocation. :-( I am fixing this here and explicitly checking for empty arguments.
I hate BASH 😢